mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Rouven Czerwinski <rouven@czerwinskis.de>
To: Peter Korsgaard <peter@korsgaard.com>
Cc: barebox@lists.infradead.org,
	Rouven Czerwinski <r.czerwinski@pengutronix.de>
Subject: Re: [PATCH v5 0/9] Raspberry Pi miniuart support
Date: Wed, 19 Dec 2018 12:28:36 +0100	[thread overview]
Message-ID: <871s6ddacb.fsf@czerwinskis.de> (raw)
In-Reply-To: <87efad2a3k.fsf@dell.be.48ers.dk>


Peter Korsgaard <peter@korsgaard.com> writes:

>>>>>> "Rouven" == Rouven Czerwinski <r.czerwinski@pengutronix.de> writes:
>
> Hi,
>
>  >> >> v5:
>  >> >> - Add defines for register and base values
>  >> >> from Sascha Hauer and Roland Hieber
>  >> 
>  >> > Applied, thanks
>  >> 
>  >> Where did those defines actually go? I still see a bunch of magic
>  >> values.
>  >> 
>  > They are either contained directly in the original patch (for 5/9) or
>  > in the new 9/9 patch.
>
> Sorry, I don't follow. I still see magic values in E.G.:
>
> 97818de1a3d serial_ns16550: add raspberry pi compatible and init
> 776de843636 ARM: rpi: retrieve miniuart clock from firmware
>
> Wasn't this comment about replacing them with sensible defines?

Looking at the patches again the change to defines for the AUX Clock
domain was squashed into the wrong commit.

I'll resend the corrected version.

Thanks for noticing.

- Rouven

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

      parent reply	other threads:[~2018-12-19 11:28 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-18 10:47 Rouven Czerwinski
2018-12-18 10:47 ` [PATCH v5 1/9] ARM: rpi: fix typo in rpi-common.c Rouven Czerwinski
2018-12-18 10:47 ` [PATCH v5 2/9] ARM: rpi: move clks into board specific rpi-common Rouven Czerwinski
2018-12-18 10:47 ` [PATCH v5 3/9] ARM: rpi: retrieve miniuart clock from firmware Rouven Czerwinski
2018-12-18 10:47 ` [PATCH v5 4/9] serial_ns16550: handle default reg-io-width Rouven Czerwinski
2018-12-18 10:47 ` [PATCH v5 5/9] serial_ns16550: add raspberry pi compatible and init Rouven Czerwinski
2018-12-18 10:47 ` [PATCH v5 6/9] ARM: rpi: add NS16550 support Rouven Czerwinski
2018-12-19 11:26   ` Rouven Czerwinski
2018-12-18 10:47 ` [PATCH v5 7/9] ARM: rpi: choose miniuart as stdout Rouven Czerwinski
2018-12-18 10:47 ` [PATCH v5 8/9] doc: bcm283x: remove miniuart overlay instruction Rouven Czerwinski
2018-12-18 10:47 ` [PATCH v5 9/9] ARM: rpi: use defines for uart bases Rouven Czerwinski
2018-12-18 14:06 ` [PATCH v5 0/9] Raspberry Pi miniuart support Sascha Hauer
2018-12-18 14:26   ` Peter Korsgaard
2018-12-19  5:21     ` Rouven Czerwinski
2018-12-19  8:29       ` Peter Korsgaard
2018-12-19  8:37         ` Rouven Czerwinski
2018-12-19 11:28         ` Rouven Czerwinski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871s6ddacb.fsf@czerwinskis.de \
    --to=rouven@czerwinskis.de \
    --cc=barebox@lists.infradead.org \
    --cc=peter@korsgaard.com \
    --cc=r.czerwinski@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox