From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from magratgarlick.emantor.de ([78.46.208.201] helo=margratgarlick.emantor.de) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gZXMV-0003ko-TJ for barebox@lists.infradead.org; Wed, 19 Dec 2018 08:37:53 +0000 References: <20181218140606.lmubb4dff77khwgq@pengutronix.de> <87mup229o8.fsf@dell.be.48ers.dk> <7c265230ded826f59b0a4e16f90abd6ec5d6c4a2.camel@pengutronix.de> <87efad2a3k.fsf@dell.be.48ers.dk> From: Rouven Czerwinski In-reply-to: <87efad2a3k.fsf@dell.be.48ers.dk> Date: Wed, 19 Dec 2018 09:37:37 +0100 Message-ID: <874lb9di9a.fsf@czerwinskis.de> MIME-Version: 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH v5 0/9] Raspberry Pi miniuart support To: Peter Korsgaard Cc: barebox@lists.infradead.org, Rouven Czerwinski Peter Korsgaard writes: >>>>>> "Rouven" == Rouven Czerwinski writes: > > Hi, > > >> >> v5: > >> >> - Add defines for register and base values > >> >> from Sascha Hauer and Roland Hieber > >> > >> > Applied, thanks > >> > >> Where did those defines actually go? I still see a bunch of magic > >> values. > >> > > They are either contained directly in the original patch (for 5/9) or > > in the new 9/9 patch. > > Sorry, I don't follow. I still see magic values in E.G.: > > 97818de1a3d serial_ns16550: add raspberry pi compatible and init > 776de843636 ARM: rpi: retrieve miniuart clock from firmware > > Wasn't this comment about replacing them with sensible defines? Yes, looking into the next branch, it still contains the old patchset without the defines. Maybe Sascha has not pushed yet? - Rouven _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox