From: Rouven Czerwinski <rouven@czerwinskis.de>
To: Rouven Czerwinski <r.czerwinski@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH v3 4/7] serial_ns16550: add raspberry pi compatible and init
Date: Mon, 17 Dec 2018 09:06:49 +0100 [thread overview]
Message-ID: <875zvsd1ba.fsf@czerwinskis.de> (raw)
In-Reply-To: <9be8668f9a90a48ca8225832d02d76413635a98a.1545031438.git-series.r.czerwinski@pengutronix.de>
Rouven Czerwinski <r.czerwinski@pengutronix.de> writes:
> Add the compatible for the Raspberry Pi AUX UART and an init function which
> enables it via the aux register and configures the correct shift value.
>
> Signed-off-by: Rouven Czerwinski <r.czerwinski@pengutronix.de>
> ---
> drivers/serial/serial_ns16550.c | 25 +++++++++++++++++++++++++
> 1 file changed, 25 insertions(+)
>
> diff --git a/drivers/serial/serial_ns16550.c b/drivers/serial/serial_ns16550.c
> index 8ddcfdb..34b83f4 100644
> --- a/drivers/serial/serial_ns16550.c
> +++ b/drivers/serial/serial_ns16550.c
> @@ -253,6 +253,20 @@ static void ns16550_jz_init_port(struct console_device *cdev)
> ns16550_serial_init_port(cdev);
> }
>
> +static void rpi_init_port(struct console_device *cdev)
> +{
> + struct ns16550_priv *priv = to_ns16550_priv(cdev);
> +
> + writeb(0x01, 0x3f215004);
> + priv->plat.shift = 2;
> + /*
> + * We double the clock rate since the 16550 will divide by 16
> + * (instead of 8 required by the BCM2835 peripheral manual)
> + */
> + priv->plat.clock = priv->plat.clock*2;
> + ns16550_serial_init_port(cdev);
> +}
> +
> /*********** Exposed Functions **********************************/
>
> /**
> @@ -353,6 +367,11 @@ static __maybe_unused struct ns16550_drvdata tegra_drvdata = {
> .linux_console_name = "ttyS",
> };
>
> +static struct ns16550_drvdata rpi_drvdata = {
__maybe unused missing here.
> + .init_port = rpi_init_port,
> + .linux_console_name = "ttyS",
> +};
> +
> static int ns16550_init_iomem(struct device_d *dev, struct ns16550_priv *priv)
> {
> struct resource *iores;
> @@ -528,6 +547,12 @@ static struct of_device_id ns16550_serial_dt_ids[] = {
> .data = &jz_drvdata,
> },
> #endif
> +#if IS_ENABLED(CONFIG_MACH_RPI_COMMON)
> + {
> + .compatible = "brcm,bcm2835-aux-uart",
> + .data = &rpi_drvdata,
The indentation is still wrong.
Will send a v4.
> + },
> +#endif
> {
> /* sentinel */
> },
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2018-12-17 8:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-17 7:27 [PATCH v3 0/7] Raspberry Pi miniuart support Rouven Czerwinski
2018-12-17 7:28 ` [PATCH v3 1/7] ARM: rpi: move clks into board specific rpi-common Rouven Czerwinski
2018-12-17 7:28 ` [PATCH v3 2/7] ARM: rpi: retrieve miniuart clock from firmware Rouven Czerwinski
2018-12-17 7:28 ` [PATCH v3 3/7] serial_ns16550: handle default reg-io-width Rouven Czerwinski
2018-12-17 7:28 ` [PATCH v3 4/7] serial_ns16550: add raspberry pi compatible and init Rouven Czerwinski
2018-12-17 8:06 ` Rouven Czerwinski [this message]
2018-12-17 7:28 ` [PATCH v3 5/7] ARM: rpi: add NS16550 support Rouven Czerwinski
2018-12-17 7:28 ` [PATCH v3 6/7] ARM: rpi: choose miniuart as stdout Rouven Czerwinski
2018-12-17 7:28 ` [PATCH v3 7/7] doc: bcm283x: remove miniuart overlay instruction Rouven Czerwinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875zvsd1ba.fsf@czerwinskis.de \
--to=rouven@czerwinskis.de \
--cc=barebox@lists.infradead.org \
--cc=r.czerwinski@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox