mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Robert Jarzmik <robert.jarzmik@free.fr>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] drivers/pwm: add PXA pulse width modulator controller
Date: Thu, 09 Feb 2012 12:50:17 +0100	[thread overview]
Message-ID: <877gzw445i.fsf@free.fr> (raw)
In-Reply-To: <20120209081045.GU3852@pengutronix.de> (Sascha Hauer's message of "Thu, 9 Feb 2012 09:10:45 +0100")

Sascha Hauer <s.hauer@pengutronix.de> writes:
> Experience shows that the framebuffer shouldn't be enabled on
> initialization time. If it does you end up with a framebuffer showing
> a blank screen in the best case. Instead the framebuffer should be
> enabled explicitely once there is an image on the screen which looks
> much nicer to the user. That said the following should be removed from
> the pxafb driver:
>
> 	if (pdata->enable_on_load)
> 		info->fbops->fb_enable(info);
>
> Are you ok with that?
For the pxafb, yes agreed.

I still see a small issue with the PWM API.
When I register the pxa-pwm driver, I have :
 pxa_pwm_probe(struct device_d *dev)
   -> base = dev_request_mem_region(dev, 0);
   -> pxa_pwm = xzalloc(...)
   -> pxa_pwm->name = drv_name(...)
   -> pxa_pwm->ops = &pxa_pwm_ops,
   -> pwmchip_add(pxa_pwm)

As you can see, the "base" is lost, and I have no way to store it in the
pwm_chip structure.

Shouldn't the pwm_chip structure have a priv pointer ?

Cheers.

--
Robert

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2012-02-09 11:50 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-31  9:36 [PATCH] Add pwm core support Sascha Hauer
2012-02-01  8:20 ` Robert Jarzmik
2012-02-01 22:42 ` [PATCH] drivers/pwm: add PXA pulse width modulator controller Robert Jarzmik
2012-02-03  9:52   ` Sascha Hauer
2012-02-03 15:39     ` Robert Jarzmik
2012-02-08 15:26       ` Robert Jarzmik
2012-02-09  8:10         ` Sascha Hauer
2012-02-09 11:50           ` Robert Jarzmik [this message]
2012-02-09 13:44             ` Sascha Hauer
2012-02-09 14:30               ` Robert Jarzmik
2012-02-14 12:58             ` [PATCH V2 1/2] " Robert Jarzmik
2012-02-14 12:58               ` [PATCH V2 2/2] drivers/video: remove pxafb enable on load Robert Jarzmik
2012-02-15  8:32               ` [PATCH V2 1/2] drivers/pwm: add PXA pulse width modulator controller Sascha Hauer
2012-02-15 11:22                 ` Robert Jarzmik
2012-02-15 15:21                 ` Robert Jarzmik
2012-02-16  7:40                   ` Sascha Hauer
2012-02-16 18:23                     ` [PATCH V3 1/3] drivers/pwm: add duty_ns and period_ns to core pwm chip Robert Jarzmik
2012-02-16 18:23                       ` [PATCH V3 2/3] drivers/pwm: add PXA pulse width modulator controller Robert Jarzmik
2012-02-16 18:23                       ` [PATCH V3 3/3] drivers/video: remove pxafb enable on load Robert Jarzmik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877gzw445i.fsf@free.fr \
    --to=robert.jarzmik@free.fr \
    --cc=barebox@lists.infradead.org \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox