From: Rouven Czerwinski <r.czerwinski@pengutronix.de>
To: barebox@lists.infradead.org
Cc: Rouven Czerwinski <r.czerwinski@pengutronix.de>
Subject: [PATCH v2 01/16] i.MX: HABv4: ignore return for i.MX28/6 initcalls
Date: Mon, 5 Aug 2019 11:23:40 +0200 [thread overview]
Message-ID: <87c364fcd198e97267c8baa0655e605b110e99a8.1564997015.git-series.r.czerwinski@pengutronix.de> (raw)
In-Reply-To: <cover.b9d503ab98014278972f6bd84931035a5ef27967.1564997015.git-series.r.czerwinski@pengutronix.de>
Move the status call below the explanations and return Null.
No functional changes intended.
Signed-off-by: Rouven Czerwinski <r.czerwinski@pengutronix.de>
---
drivers/hab/habv4.c | 18 +++++-------------
1 file changed, 5 insertions(+), 13 deletions(-)
diff --git a/drivers/hab/habv4.c b/drivers/hab/habv4.c
index 6a60be6..b11cf7b 100644
--- a/drivers/hab/habv4.c
+++ b/drivers/hab/habv4.c
@@ -511,21 +511,17 @@ int imx6_hab_get_status(void)
static int init_imx6_hab_get_status(void)
{
- int ret = 0;
-
if (!cpu_is_mx6())
/* can happen in multi-image builds and is not an error */
return 0;
- ret = imx6_hab_get_status();
-
/*
* Nobody will check the return value if there were HAB errors, but the
* initcall will fail spectaculously with a strange error message.
*/
- if (ret == -EPERM)
- return 0;
- return ret;
+ imx6_hab_get_status();
+
+ return 0;
}
/*
@@ -544,19 +540,15 @@ int imx28_hab_get_status(void)
static int init_imx28_hab_get_status(void)
{
- int ret = 0;
-
if (!cpu_is_mx28())
/* can happen in multi-image builds and is not an error */
return 0;
- ret = imx28_hab_get_status();
/* nobody will check the return value if there were HAB errors, but the
* initcall will fail spectaculously with a strange error message. */
- if (ret == -EPERM)
- return 0;
- return ret;
+ imx28_hab_get_status();
+ return 0;
}
/* i.MX28 ROM code can be run after MMU setup to make use of caching */
postmmu_initcall(init_imx28_hab_get_status);
--
git-series 0.9.1
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2019-08-05 9:24 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-05 9:23 [PATCH v2 00/16] HAB for i.MX8MQ Rouven Czerwinski
2019-08-05 9:23 ` Rouven Czerwinski [this message]
2019-08-05 9:23 ` [PATCH v2 02/16] i.MX: HABv4: implement interface " Rouven Czerwinski
2019-08-05 12:12 ` Lucas Stach
2019-08-05 9:23 ` [PATCH v2 03/16] mach-imx: enable HAB on i.MX8MQ Rouven Czerwinski
2019-08-05 9:23 ` [PATCH v2 04/16] arm: lib: add CSF section between PBL and piggy Rouven Czerwinski
2019-08-05 9:23 ` [PATCH v2 05/16] esdhc-pbl: extract header parsing from image start Rouven Czerwinski
2019-08-05 9:23 ` [PATCH v2 06/16] esdhc-pbl: add piggy load function Rouven Czerwinski
2019-08-05 9:23 ` [PATCH v2 07/16] sections: fix macro for barebox_pbl_size Rouven Czerwinski
2019-08-05 9:23 ` [PATCH v2 08/16] scripts: imx: support signing for i.MX8MQ Rouven Czerwinski
2019-08-05 9:23 ` [PATCH v2 09/16] images: always build sha256sum into pbl Rouven Czerwinski
2019-08-05 12:20 ` Lucas Stach
2019-08-05 12:52 ` Rouven Czerwinski
2019-08-05 9:23 ` [PATCH v2 10/16] pbl: add sha256 and piggy verification to PBL Rouven Czerwinski
2019-08-05 11:00 ` Lucas Stach
2019-08-05 12:57 ` Rouven Czerwinski
2019-08-05 9:23 ` [PATCH v2 11/16] stdio: puts and putchar static inline wrappers Rouven Czerwinski
2019-08-05 9:23 ` [PATCH v2 12/16] pbl: support panic with log output Rouven Czerwinski
2019-08-05 9:23 ` [PATCH v2 13/16] arm: uncompress: verify sha256 if enabled Rouven Czerwinski
2019-08-05 10:42 ` Lucas Stach
2019-08-05 9:23 ` [PATCH v2 14/16] mach-imx: add gencsf header for i.MX8MQ Rouven Czerwinski
2019-08-05 9:23 ` [PATCH v2 15/16] mach-imx: hab: select piggy verification for i.MX8 Rouven Czerwinski
2019-08-05 10:39 ` Lucas Stach
2019-08-05 9:23 ` [PATCH v2 16/16] boards: nxp-mx8-evk: rework to different boot flow Rouven Czerwinski
2019-08-05 10:37 ` Lucas Stach
2019-08-05 12:59 ` Rouven Czerwinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87c364fcd198e97267c8baa0655e605b110e99a8.1564997015.git-series.r.czerwinski@pengutronix.de \
--to=r.czerwinski@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox