From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail.savoirfairelinux.com ([208.88.110.44]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1fJm6q-0005dG-Rr for barebox@lists.infradead.org; Fri, 18 May 2018 20:36:20 +0000 From: Vivien Didelot In-Reply-To: <20180518202045.GA26895@ravnborg.org> References: <20180518180636.24885-1-vivien.didelot@savoirfairelinux.com> <20180518202045.GA26895@ravnborg.org> Date: Fri, 18 May 2018 16:36:04 -0400 Message-ID: <87d0xsbt1n.fsf@weeman.i-did-not-set--mail-host-address--so-tickle-me> MIME-Version: 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH] net: specify device name in warning To: Sam Ravnborg Cc: barebox@lists.infradead.org Hi Sam, Sam Ravnborg writes: > On Fri, May 18, 2018 at 02:06:36PM -0400, Vivien Didelot wrote: >> When a SoC such as VF610 has no addresses programmed for both its >> interfaces, the "No MAC address set" warning can be confusing: >> >> booting 'net' >> WARNING: net: warning: No MAC address set. Using random address a2:e8:be:79:72:01 >> WARNING: net: warning: No MAC address set. Using random address aa:d5:d7:10:c0:42 >> >> This patch simply specifies the device name in the warning for clarity: >> >> booting 'net' >> WARNING: net: warning: No MAC address set for eth0. Using random address 5e:92:6b:b8:6e:92 >> WARNING: net: warning: No MAC address set for eth1. Using random address 7e:bb:cd:7a:c1:e8 >> >> Signed-off-by: Vivien Didelot >> --- >> net/net.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/net/net.c b/net/net.c >> index 94954677c..da7afb014 100644 >> --- a/net/net.c >> +++ b/net/net.c >> @@ -330,7 +330,7 @@ static struct net_connection *net_new(struct eth_device *edev, IPaddr_t dest, >> char str[sizeof("xx:xx:xx:xx:xx:xx")]; >> random_ether_addr(edev->ethaddr); >> ethaddr_to_string(edev->ethaddr, str); >> - pr_warn("warning: No MAC address set. Using random address %s\n", str); >> + pr_warn("warning: No MAC address set for %s. Using random address %s\n", edev->devname, str); >> eth_set_ethaddr(edev, edev->ethaddr); > > You have a device - so a more consistent way seems to use dev_warn() This looks better indeed, I'll respin! Thanks, Vivien _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox