From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-ed1-x542.google.com ([2a00:1450:4864:20::542]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gZXEU-0007v3-IS for barebox@lists.infradead.org; Wed, 19 Dec 2018 08:29:36 +0000 Received: by mail-ed1-x542.google.com with SMTP id x30so16225264edx.2 for ; Wed, 19 Dec 2018 00:29:23 -0800 (PST) From: Peter Korsgaard References: <20181218140606.lmubb4dff77khwgq@pengutronix.de> <87mup229o8.fsf@dell.be.48ers.dk> <7c265230ded826f59b0a4e16f90abd6ec5d6c4a2.camel@pengutronix.de> Date: Wed, 19 Dec 2018 09:29:19 +0100 In-Reply-To: <7c265230ded826f59b0a4e16f90abd6ec5d6c4a2.camel@pengutronix.de> (Rouven Czerwinski's message of "Wed, 19 Dec 2018 06:21:40 +0100") Message-ID: <87efad2a3k.fsf@dell.be.48ers.dk> MIME-Version: 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH v5 0/9] Raspberry Pi miniuart support To: Rouven Czerwinski Cc: barebox@lists.infradead.org >>>>> "Rouven" == Rouven Czerwinski writes: Hi, >> >> v5: >> >> - Add defines for register and base values >> >> from Sascha Hauer and Roland Hieber >> >> > Applied, thanks >> >> Where did those defines actually go? I still see a bunch of magic >> values. >> > They are either contained directly in the original patch (for 5/9) or > in the new 9/9 patch. Sorry, I don't follow. I still see magic values in E.G.: 97818de1a3d serial_ns16550: add raspberry pi compatible and init 776de843636 ARM: rpi: retrieve miniuart clock from firmware Wasn't this comment about replacing them with sensible defines? -- Bye, Peter Korsgaard _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox