From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from smtp12.smtpout.orange.fr ([80.12.242.134] helo=smtp.smtpout.orange.fr) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1ZkdA3-00032E-Ii for barebox@lists.infradead.org; Fri, 09 Oct 2015 19:17:00 +0000 From: Robert Jarzmik References: <1444341979-19157-1-git-send-email-sebastian.hesselbarth@gmail.com> <1444341979-19157-2-git-send-email-sebastian.hesselbarth@gmail.com> Date: Fri, 09 Oct 2015 21:11:13 +0200 In-Reply-To: <1444341979-19157-2-git-send-email-sebastian.hesselbarth@gmail.com> (Sebastian Hesselbarth's message of "Fri, 9 Oct 2015 00:06:03 +0200") Message-ID: <87egh3amcu.fsf@belgarion.home> MIME-Version: 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH 01/17] arm: pxa: Prepare for NAND clkdev lookup on PXA3xx To: Sebastian Hesselbarth Cc: Thomas Petazzoni , barebox@lists.infradead.org, Ezequiel Garcia Sebastian Hesselbarth writes: > To allow PXA3xx nand driver to be reused on Marvell Armada 370/XP, > prepare to provide a common clock for the NAND driver on PXA3xx. > > Signed-off-by: Sebastian Hesselbarth Hi Sebastian, I have several questions on the serie : - on which tree did you base that serie ? This patch for example doesn't apply on top of the trees I have - do you know that PXA has already support for the common clock framework (see drivers/clk/pxa/*) ? As a consequence, CLKDEV_LOOKUP, COMMON_CLK, etc ... are already selected. Moreover, I won't take patches to speed-pxa3xx.c unless there is a really strong reason; at least it should be stronger than a simple clk_get(dev, NULL) solution. Cheers. -- Robert _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox