From: Peter Korsgaard <jacmet@sunsite.dk>
To: barebox@lists.infradead.org, s.hauer@pengutronix.de
Subject: Re: [PATCH] Fix sandbox ./barebox --help by reverting 6b082cfe (fix printf warnings)
Date: Thu, 26 May 2011 10:02:57 +0200 [thread overview]
Message-ID: <87ei3lriry.fsf@macbook.be.48ers.dk> (raw)
In-Reply-To: <1305408544-29710-1-git-send-email-jacmet@sunsite.dk> (Peter Korsgaard's message of "Sat, 14 May 2011 23:29:04 +0200")
>>>>> "Peter" == Peter Korsgaard <jacmet@sunsite.dk> writes:
Peter> While getting rid of all the format(barebox_printf) warnings was nice,
Peter> it caused the printf calls in arch/sandbox/os/common.c to get directed
Peter> to the barebox versions rather than the libc ones causing a crash:
Peter> E.G. before this revert:
Peter> nm -a barebox|grep -w printf
Peter> 0000000000404fa3 T print
Peter> And after:
Peter> nm -a barebox|grep -w printf
Peter> U printf@@GLIBC_2.2.5
Peter> Signed-off-by: Peter Korsgaard <jacmet@sunsite.dk>
Ping?
Peter> ---
Peter> include/stdio.h | 5 -----
Peter> 1 files changed, 0 insertions(+), 5 deletions(-)
Peter> diff --git a/include/stdio.h b/include/stdio.h
Peter> index 9b1f161..c824764 100644
Peter> --- a/include/stdio.h
Peter> +++ b/include/stdio.h
Peter> @@ -8,9 +8,6 @@
Peter> * STDIO based functions (can always be used)
Peter> */
Peter> -#define ORIG_printf printf
Peter> -#undef printf
Peter> -
Peter> /* serial stuff */
Peter> void serial_printf(const char *fmt, ...) __attribute__ ((format(printf, 1, 2)));
Peter> @@ -63,6 +60,4 @@ int fputc(int file, const char c);
Peter> int ftstc(int file);
Peter> int fgetc(int file);
Peter> -#define printf ORIG_printf
Peter> -
Peter> #endif /* __STDIO_H */
Peter> --
Peter> 1.7.4.4
--
Bye, Peter Korsgaard
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2011-05-26 8:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-14 21:29 Peter Korsgaard
2011-05-26 8:02 ` Peter Korsgaard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ei3lriry.fsf@macbook.be.48ers.dk \
--to=jacmet@sunsite.dk \
--cc=barebox@lists.infradead.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox