From: Robert Jarzmik <robert.jarzmik@free.fr>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 1/2] net: smc1111: fix platform data initializations
Date: Mon, 13 Apr 2015 19:53:21 +0200 [thread overview]
Message-ID: <87h9sjvrse.fsf@free.fr> (raw)
In-Reply-To: <20150413072112.GB9742@pengutronix.de> (Sascha Hauer's message of "Mon, 13 Apr 2015 09:21:12 +0200")
Sascha Hauer <s.hauer@pengutronix.de> writes:
> On Sat, Apr 11, 2015 at 11:42:41PM +0200, Robert Jarzmik wrote:
>> pdata->config_setup = pdata->config_setup;
>> pdata->control_setup = pdata->control_setup;
>> + priv->config_setup = pdata->config_setup;
>> + priv->control_setup = pdata->control_setup;
>
> This should be:
>
> if (pdata->bus_width == 16)
> priv->a = access_via_16bit;
> - pdata->config_setup = pdata->config_setup;
> - pdata->control_setup = pdata->control_setup;
> + priv->config_setup = pdata->config_setup;
> + priv->control_setup = pdata->control_setup;
> }
>
> Fixed this while applying because this is master material and I want to
> make a release today.
Silly me, you're very right, thanks for the "on the fly" repatching.
Cheers.
--
Robert
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2015-04-13 17:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-11 21:42 Robert Jarzmik
2015-04-11 21:42 ` [PATCH 2/2] net: smc1111: add a quirk for pxa pxa27x platforms Robert Jarzmik
2015-04-13 7:21 ` [PATCH 1/2] net: smc1111: fix platform data initializations Sascha Hauer
2015-04-13 17:53 ` Robert Jarzmik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h9sjvrse.fsf@free.fr \
--to=robert.jarzmik@free.fr \
--cc=barebox@lists.infradead.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox