From: Robert Jarzmik <robert.jarzmik@free.fr>
To: Marc Kleine-Budde <mkl@pengutronix.de>
Cc: barebox@lists.infradead.org, Luotao Fu <l.fu@pengutronix.de>
Subject: Re: [PATCH V2 1/3] arm/mach-pxa: Initial Intel/Marvell PXA support
Date: Sun, 27 Nov 2011 23:23:37 +0100 [thread overview]
Message-ID: <87sjl98as6.fsf@free.fr> (raw)
In-Reply-To: <4ED16DE0.1010700@pengutronix.de> (Marc Kleine-Budde's message of "Sat, 26 Nov 2011 23:53:20 +0100")
Marc Kleine-Budde <mkl@pengutronix.de> writes:
> On 11/26/2011 01:17 PM, Robert Jarzmik wrote:
>> From: Marc Kleine-Budde <mkl@pengutronix.de>
>>
>> The core support was brought by Marc and Sascha.
>> The cache choice was fixed by Luotao Fu.
>> Some gpio and devices addons were provided by Robert.
>>
>> Signed-off-by: Robert Jarzmik <robert.jarzmik@free.fr>
>> Signed-off-by: Luotao Fu <l.fu@pengutronix.de>
>> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
>> Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
>
> Nitpick: Your S-o-b should be the last one.
> ...more nitpicking inline
Yep.
I think I'll take that patch over a bit more.
As it had some signoffs, I didn't take any time to fix it. Now you're asking for
more, I'll fix it more deeply, so that checkpatch doesn't complain, neither
sparse.
That means the former signoffs will have to be given again I'm afraid.
>> +# Xscale PXA25x, PXA27x
>> +config CPU_XSCALE
>> + bool
>> + select CPU_32v4T
>
> Sascha, which CPU is the correct one?
If your question is "is the PXA a 32bits, ARMv5, with MMU/caches of the ARMv4
variant", then the answer is yes. The linux kernel agrees with Intel
specification on that point.
...zip...
>> + * You should have received a copy of the GNU General Public License
>> + * along with this program; if not, write to the Free Software
>> + * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
>> + * MA 02111-1307 USA
>> + */
>
> please remove the FSF's address.
Sure, for all occurences.
>> diff --git a/arch/arm/mach-pxa/gpio.c b/arch/arm/mach-pxa/gpio.c
>> new file mode 100644
>> index 0000000..f0c8c99
>> --- /dev/null
>> +++ b/arch/arm/mach-pxa/gpio.c
>> @@ -0,0 +1,70 @@
>> +/*
>> + * linux/arch/arm/plat-pxa/gpio.c
>
> can you adjust the path or remove it completely?
Remove, yes.
--
Robert
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2011-11-27 22:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-26 12:17 [PATCH V2 0/3] Initial PXA support and Mitac MIOA701 board Robert Jarzmik
2011-11-26 12:17 ` [PATCH V2 1/3] arm/mach-pxa: Initial Intel/Marvell PXA support Robert Jarzmik
2011-11-26 22:53 ` Marc Kleine-Budde
2011-11-27 22:23 ` Robert Jarzmik [this message]
2011-11-26 12:17 ` [PATCH V2 2/3] drivers/video: add PXA framebuffer support Robert Jarzmik
2011-11-26 12:17 ` [PATCH V2 3/3] arm/mach-pxa: add mioa701 board Robert Jarzmik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sjl98as6.fsf@free.fr \
--to=robert.jarzmik@free.fr \
--cc=barebox@lists.infradead.org \
--cc=l.fu@pengutronix.de \
--cc=mkl@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox