From: Robert Jarzmik <robert.jarzmik@free.fr>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 7/7] nand-bb: implement lseek in readonly mode
Date: Thu, 15 Dec 2011 16:51:50 +0100 [thread overview]
Message-ID: <87ty51x27d.fsf@free.fr> (raw)
In-Reply-To: <20111215152133.GT27267@pengutronix.de> (Sascha Hauer's message of "Thu, 15 Dec 2011 16:21:33 +0100")
Sascha Hauer <s.hauer@pengutronix.de> writes:
> This one should work like expected:
>
> while (raw_pos < bb->raw_size) {
> off_t now = min(offset, bb->info.erasesize);
>
> ret = cdev_ioctl(bb->cdev_parent, MEMGETBADBLOCK, (void *)raw_pos);
> if (ret < 0)
> return ret;
> if (!ret) {
> offset -= now;
> raw_pos += now;
> } else {
> raw_pos += bb->info.erasesize
> }
> if (!offset) {
> bb->offset = raw_pos;
> return __offset;
> }
> }
Yup, looks good.
If you wish, you can add my :
Reviewed-by: Robert Jarzmik <robert.jarzmik@free.fr>
Cheers.
--
Robert
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2011-12-15 15:52 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-15 10:49 misc patches Sascha Hauer
2011-12-15 10:49 ` [PATCH 1/7] remove unused watchdog header Sascha Hauer
2011-12-15 10:49 ` [PATCH 2/7] remove unused keyboard.h file Sascha Hauer
2011-12-15 10:49 ` [PATCH 3/7] ARM cpuinfo: decode more bits, use ARRAY_SIZE Sascha Hauer
2011-12-15 10:49 ` [PATCH 4/7] ARM: remove unused icache command Sascha Hauer
2011-12-15 10:49 ` [PATCH 5/7] common.h: remove unused function declarations Sascha Hauer
2011-12-15 10:49 ` [PATCH 6/7] cdev: pass flags to open function Sascha Hauer
2011-12-15 10:49 ` [PATCH 7/7] nand-bb: implement lseek in readonly mode Sascha Hauer
2011-12-15 13:51 ` Robert Jarzmik
2011-12-15 15:21 ` Sascha Hauer
2011-12-15 15:51 ` Robert Jarzmik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ty51x27d.fsf@free.fr \
--to=robert.jarzmik@free.fr \
--cc=barebox@lists.infradead.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox