From: Robert Jarzmik <robert.jarzmik@free.fr>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 9/9] arm/mach-pxa: add mioa701 board
Date: Thu, 24 Nov 2011 22:22:08 +0100 [thread overview]
Message-ID: <87zkflw70f.fsf@free.fr> (raw)
In-Reply-To: <20111124094525.GB27267@pengutronix.de> (Sascha Hauer's message of "Thu, 24 Nov 2011 10:45:25 +0100")
Sascha Hauer <s.hauer@pengutronix.de> writes:
> Are the defines in this file used by generic code? If not, please put
> them into a board specific include file (or remove them if they are
> unused)
I intended to use these values in lowlevel_init.S. Isn't that the right place ?
>> diff --git a/arch/arm/boards/mioa701/lowlevel_init.S b/arch/arm/boards/mioa701/lowlevel_init.S
>> + .section ".text_bare_init","ax"
>> +.global board_init_lowlevel
>> +board_init_lowlevel:
>> + mov r10, lr
>> + /*
>> + * This piece of code should ensure at least:
>> + * - getting SDRAM out of self-refresh, and/or setup SDRAM timings
>> + * - putting the GPIO logic into a usable state
>> + bl stabilize_reset
>> + bl setup_sdram
>> + bl setup_gpios
>
> I can't find these functions in the patch. Is this used?
It's ... within a comment because these functions are not written yet. This is
where the config.h values will be used, and the 3 functions should be coded in a
next step.
Cheers.
--
Robert
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2011-11-24 21:22 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-24 3:02 [PATCH 0/9] Initial PXA support and Mitac MIOA701 board Robert Jarzmik
2011-11-24 3:02 ` [PATCH 1/9] initial Intel/Marvell PXA support Robert Jarzmik
2011-11-24 9:29 ` Sascha Hauer
2011-11-25 21:26 ` Robert Jarzmik
2011-11-24 3:02 ` [PATCH 2/9] fix association of cache handling code for PXA Robert Jarzmik
2011-11-24 3:02 ` [PATCH 3/9] fix core version selection Robert Jarzmik
2011-11-24 3:02 ` [PATCH 4/9] add PXA framebuffer support Robert Jarzmik
2011-11-24 3:02 ` [PATCH 5/9] drivers: pxafb: Fix IOMEM API evolution Robert Jarzmik
2011-11-24 3:02 ` [PATCH 6/9] drivers: pxafb: add include ifdefery Robert Jarzmik
2011-11-24 3:02 ` [PATCH 7/9] arm/mach-pxa: add gpio direction functions Robert Jarzmik
2011-11-24 3:02 ` [PATCH 8/9] arm/mach-pxa: add basic devices hooks Robert Jarzmik
2011-11-24 3:02 ` [PATCH 9/9] arm/mach-pxa: add mioa701 board Robert Jarzmik
2011-11-24 9:13 ` Marc Kleine-Budde
2011-11-24 21:15 ` Robert Jarzmik
2011-11-24 9:45 ` Sascha Hauer
2011-11-24 21:22 ` Robert Jarzmik [this message]
2011-11-24 23:08 ` Sascha Hauer
2011-11-25 21:50 ` Robert Jarzmik
2011-11-24 9:10 ` [PATCH 0/9] Initial PXA support and Mitac MIOA701 board Marc Kleine-Budde
2011-11-24 9:28 ` Sascha Hauer
2011-11-24 21:32 ` Robert Jarzmik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zkflw70f.fsf@free.fr \
--to=robert.jarzmik@free.fr \
--cc=barebox@lists.infradead.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox