From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
barebox@lists.infradead.org
Subject: Re: [PATCH v2 1/2] watchdog: imxwd: Convert error messages in .probe to dev_err_probe()
Date: Wed, 29 Jun 2022 11:26:34 +0200 [thread overview]
Message-ID: <892ca07e-a3c7-4618-b83a-10fab9269a2c@pengutronix.de> (raw)
In-Reply-To: <20220629085628.106086-1-u.kleine-koenig@pengutronix.de>
On 29.06.22 10:56, Uwe Kleine-König wrote:
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Once there are enough dev_err_probe users, we could make it optional
to compile these strings in, so thanks for using it:
Reviewed-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> ---
> drivers/watchdog/imxwd.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/watchdog/imxwd.c b/drivers/watchdog/imxwd.c
> index 31ea388c2cf2..e9856c94c2fc 100644
> --- a/drivers/watchdog/imxwd.c
> +++ b/drivers/watchdog/imxwd.c
> @@ -239,10 +239,9 @@ static int imx_wd_probe(struct device_d *dev)
>
> priv = xzalloc(sizeof(struct imx_wd));
> iores = dev_request_mem_resource(dev, 0);
> - if (IS_ERR(iores)) {
> - dev_err(dev, "could not get memory region\n");
> - return PTR_ERR(iores);
> - }
> + if (IS_ERR(iores))
> + return dev_err_probe(dev, PTR_ERR(iores),
> + "could not get memory region\n");
>
> clk = clk_get(dev, NULL);
> if (IS_ERR(clk))
> @@ -279,7 +278,8 @@ static int imx_wd_probe(struct device_d *dev)
> if (priv->ops->init) {
> ret = priv->ops->init(priv);
> if (ret) {
> - dev_err(dev, "Failed to init watchdog device %d\n", ret);
> + dev_err_probe(dev, ret,
> + "Failed to init watchdog device\n");
> goto error_unregister;
> }
> }
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2022-06-29 9:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-29 8:56 Uwe Kleine-König
2022-06-29 8:56 ` [PATCH v2 2/2] watchdog: imxwd: Add error messages for some failure points in .probe() Uwe Kleine-König
2022-06-29 9:27 ` Ahmad Fatoum
2022-06-29 9:26 ` Ahmad Fatoum [this message]
2022-06-30 7:23 ` [PATCH v2 1/2] watchdog: imxwd: Convert error messages in .probe to dev_err_probe() Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=892ca07e-a3c7-4618-b83a-10fab9269a2c@pengutronix.de \
--to=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox