From: "Stefan Riedmüller" <s.riedmueller@phytec.de>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH v2 5/8] ARM: dts: imx6: phycard: Use partname for environment device-path
Date: Tue, 10 Dec 2019 14:38:46 +0100 [thread overview]
Message-ID: <8a2d6f08-b350-674a-65bc-a51b844bee8a@phytec.de> (raw)
In-Reply-To: <20191210104525.oee5ygpzwyhtzvha@pengutronix.de>
Hi Sascha,
On 10.12.19 11:45, Sascha Hauer wrote:
> On Tue, Dec 10, 2019 at 09:15:52AM +0100, Stefan Riedmüller wrote:
>> Hi Sascha,
>>
>> On 10.12.19 09:05, Sascha Hauer wrote:
>>> On Tue, Dec 10, 2019 at 08:50:41AM +0100, Stefan Riedmüller wrote:
>>>> Hi Sascha,
>>>>
>>>> On 09.12.19 16:37, Sascha Hauer wrote:
>>>>> On Mon, Dec 09, 2019 at 01:31:40PM +0100, Stefan Riedmueller wrote:
>>>>>> Change environment device-path from using a separate label to
>>>>>> referencing a device plus partname.
>>>>>
>>>>> Why? The way it was is fine.
>>>>
>>>> Just to be consistent with phyCORE and phyFLEX. Is there a downside I'm not
>>>> aware of?
>>>
>>> It feels more natural to directly point to the partition, that's why I
>>> prefer that way. So if you don't have a good reason I suggest to convert
>>> it the other way round for consistency
>>
>> I will recheck if there was a specific reason for us to use the partname
>> approach. But you can drop this patch for now.
>
> I just tried. The series doesn't apply on current master. Could you
> rebase it?
Yes, of course.
Stefan
>
> Sascha
>
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2019-12-10 13:38 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-09 12:31 [PATCH v2 1/8] ARM: dts: imx6: pcaaxl3: Order nodes alphabetically Stefan Riedmueller
2019-12-09 12:31 ` [PATCH v2 2/8] ARM: dts: imx6: pcaaxl3: Update license and model description Stefan Riedmueller
2019-12-09 12:31 ` [PATCH v2 3/8] ARM: dts: imx6: pcaaxl3: Make use of the simpler name phycard Stefan Riedmueller
2019-12-09 12:31 ` [PATCH v2 4/8] ARM: dts: imx6: phycard: Make eeprom configurable Stefan Riedmueller
2019-12-09 12:31 ` [PATCH v2 5/8] ARM: dts: imx6: phycard: Use partname for environment device-path Stefan Riedmueller
2019-12-09 15:37 ` Sascha Hauer
2019-12-10 7:50 ` Stefan Riedmüller
2019-12-10 8:05 ` Sascha Hauer
2019-12-10 8:15 ` Stefan Riedmüller
2019-12-10 10:45 ` Sascha Hauer
2019-12-10 13:38 ` Stefan Riedmüller [this message]
2019-12-09 12:31 ` [PATCH v2 6/8] ARM: dts: imx6: phycard: Switch to new partitions binding Stefan Riedmueller
2019-12-09 12:31 ` [PATCH v2 7/8] ARM: dts: imx6: phycard: Use gpio binding constants Stefan Riedmueller
2019-12-09 12:31 ` [PATCH v2 8/8] ARM: dts: imx6: phytec: Increase NAND barebox partition size Stefan Riedmueller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8a2d6f08-b350-674a-65bc-a51b844bee8a@phytec.de \
--to=s.riedmueller@phytec.de \
--cc=barebox@lists.infradead.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox