From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mickerik.phytec.de ([195.145.39.210]) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iReHS-0002Sz-FV for barebox@lists.infradead.org; Mon, 04 Nov 2019 15:28:36 +0000 References: <1572018968-343065-1-git-send-email-r.karszniewicz@phytec.de> <20191104094250.wn2ib2fs7hspacou@pengutronix.de> <20191104145448.7b4g4qmadpyxaygj@pengutronix.de> <20191104152148.ldmh3rrnuvcciksi@pengutronix.de> From: Robert Karszniewicz Message-ID: <8a57293c-e665-46c8-a04b-f7885315ff32@phytec.de> Date: Mon, 4 Nov 2019 16:28:33 +0100 MIME-Version: 1.0 In-Reply-To: <20191104152148.ldmh3rrnuvcciksi@pengutronix.de> Content-Language: en-US List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH] usb: storage: Increase retries for usb_stor_transport() To: barebox@lists.infradead.org On 11/4/19 4:21 PM, Marco Felsch wrote: > Hi Robert, > > On 19-11-04 15:59, Robert Karszniewicz wrote: >> On 11/4/19 3:54 PM, Marco Felsch wrote: >>> Hi Sascha, >>> >>> On 19-11-04 10:42, Sascha Hauer wrote: >>>> On Fri, Oct 25, 2019 at 05:56:08PM +0200, Robert Karszniewicz wrote: >>>>> This should make writing and reading more reliable. >>>>> >>>>> Also: >>>>> - change loop condition to make "retries" semantically correct >>>>> - add a debug message in case of fatal failure >>>>> --- >>>>> We've had problems writing (and even reading) a 10 MiB file from barebox >>>>> to multiple USB flash drives. >>>>> The 10 MiB file copy failed with "write: I/O error" almost every time. >>>>> Increasing the retry count made 100 MiB file copies succeed every time. >>>>> >>>> >>>> Doing this doesn't hurt, so I applied this patch. I wonder though if >>>> there's something else wrong which makes increasing the retry counts >>>> necessary. >>>> >>>> Sascha >>> >>> there is a missing sob is that okay with you? Robert can you add a >>> signed-off-by line? >>> >> >> Oops, I'm sorry for that! How do we handle this? Should I just amend and >> resubmit the patch? > > Resend as you already did is fine :) else you could reply with your > sob-tag. Ok! > > Regards, > Marco > >>> Regards, >>> Marco >>> >>> _______________________________________________ >>> barebox mailing list >>> barebox@lists.infradead.org >>> http://lists.infradead.org/mailman/listinfo/barebox >>> >> >> >> _______________________________________________ >> barebox mailing list >> barebox@lists.infradead.org >> http://lists.infradead.org/mailman/listinfo/barebox >> > _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox