From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Tue, 03 Jun 2025 10:08:05 +0200 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1uMMgm-003F6i-38 for lore@lore.pengutronix.de; Tue, 03 Jun 2025 10:08:04 +0200 Received: from bombadil.infradead.org ([2607:7c80:54:3::133]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1uMMgm-0004lu-AS for lore@pengutronix.de; Tue, 03 Jun 2025 10:08:04 +0200 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=YIU94J3pxhZrFIMs1+uD+nIXqWVQAcnOZXsZyu6UV7U=; b=2ZFr/uXKsen/rymyCtexhaVFwJ 6k1wg1Kz+9+zGTEw54349MOW0q+/xOwKsnDAhyIV5XbIqZLfmOrd8koaINaRSKwPY6sZp9k3JiAdw 43Mm4B12b/JtKX+5LThq+3bEwy+8nV44YjSA0ofQUlbU8R1+f2yH5IDlmOUL0ctd62XLoNnKrqszn ul16oKkZFSHFdSuhGg3nkK1ivfZmIvMOHGZoukSrfVNFWzGzfSkXVPQsmyi3XFqwsrrieECRRmzQ4 V1cde/L92coVwxNegaNUxFN1LjxZA2mLHgIOoXzCbnlo5QCYZ255P7xazQVqgu/MAJZR3Ky0CLJKC nMoCeGzA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uMMgK-0000000AGG0-30qv; Tue, 03 Jun 2025 08:07:36 +0000 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1uMMgI-0000000AGEl-0uwd for barebox@lists.infradead.org; Tue, 03 Jun 2025 08:07:35 +0000 Received: from ptz.office.stw.pengutronix.de ([2a0a:edc0:0:900:1d::77] helo=[127.0.0.1]) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1uMMgF-0004Pv-FK; Tue, 03 Jun 2025 10:07:31 +0200 Message-ID: <8b646b1b-e82d-45e0-8183-14886e144355@pengutronix.de> Date: Tue, 3 Jun 2025 10:07:31 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: barebox@lists.infradead.org Cc: Fabian Pflug References: <20250602145521.2801745-1-a.fatoum@pengutronix.de> Content-Language: en-US, de-DE, de-BE From: Ahmad Fatoum In-Reply-To: <20250602145521.2801745-1-a.fatoum@pengutronix.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250603_010734_262367_4B51B382 X-CRM114-Status: GOOD ( 22.94 ) X-BeenThere: barebox@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "barebox" X-SA-Exim-Connect-IP: 2607:7c80:54:3::133 X-SA-Exim-Mail-From: barebox-bounces+lore=pengutronix.de@lists.infradead.org X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.whiteo.stw.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-5.3 required=4.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.2 Subject: Re: [PATCH] common: optee: improve documentation of options X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on metis.whiteo.stw.pengutronix.de) Hi, On 6/2/25 16:55, Ahmad Fatoum wrote: > CONFIG_OPTEE_SIZE and CONFIG_OPTEE_SHM_SIZE have a direct correspondence > to OP-TEE build config options, so point that out in the help text. > > Signed-off-by: Ahmad Fatoum > --- > Cc: Fabian Pflug > --- > common/Kconfig | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/common/Kconfig b/common/Kconfig > index fe50da8f3084..12982b45c59d 100644 > --- a/common/Kconfig > +++ b/common/Kconfig > @@ -1307,6 +1307,7 @@ config OPTEE_SIZE > Size to reserve in main memory for OP-TEE. > Can be larger than the actual size used by OP-TEE, this is used to prevent > barebox from using or speculating into this area. > + This should be at least as big as CFG_TZDRAM_SIZE in OP-TEE. This is not completely correct. As OPTEE_SIZE is used as offset from the end of RAM, this needs to include SHMEM as well. I will revise and resent a v2. Cheers, Ahmad > > config OPTEE_SHM_SIZE > hex > @@ -1315,7 +1316,11 @@ config OPTEE_SHM_SIZE > depends on HAVE_OPTEE > help > Size to reserve in main memory for static OP-TEE shared memory > - communication. Can be used for fixing up the OP-TEE OF node. > + communication. The OP-TEE shared memory starts directly after > + the OPTEE TZDRAM region. It should be chosen to be equivalent > + to CFG_SHMEM_SIZE in OP-TEE. > + > + This value can be used for fixing up the OP-TEE OF node. > > A shared memory size of 0 means that only dynamic shared memory > will be supported for communication with OP-TEE. This is the only -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |