From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jvgdZ-0001bg-E3 for barebox@lists.infradead.org; Wed, 15 Jul 2020 12:35:50 +0000 Message-ID: <8c21cf799ad857209c795b5db79efc476adf924f.camel@pengutronix.de> From: Lucas Stach Date: Wed, 15 Jul 2020 14:35:46 +0200 In-Reply-To: <20200715101042.29944-4-o.rempel@pengutronix.de> References: <20200715101042.29944-1-o.rempel@pengutronix.de> <20200715101042.29944-4-o.rempel@pengutronix.de> MIME-Version: 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH v2 3/3] devinfo: do not dump the device node for the root node To: Oleksij Rempel , barebox@lists.infradead.org Cc: david@protonic.nl Am Mittwoch, den 15.07.2020, 12:10 +0200 schrieb Oleksij Rempel: > In case the device is a root node, then do not dump it. Otherwise it will be a > mess. This is waaay too unspecific for a commit message. What happens without this patch and how does this patch fix it? Regards, Lucas > Signed-off-by: Oleksij Rempel > --- > commands/devinfo.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/commands/devinfo.c b/commands/devinfo.c > index 81956b1cc0..018a7c4167 100644 > --- a/commands/devinfo.c > +++ b/commands/devinfo.c > @@ -99,7 +99,7 @@ static int do_devinfo(int argc, char *argv[]) > printf("\n"); > } > #ifdef CONFIG_OFDEVICE > - if (dev->device_node) { > + if (dev->device_node && dev->device_node != of_get_root_node()) { > printf("Device node: %s\n", dev->device_node->full_name); > of_print_nodes(dev->device_node, 0); > } _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox