Re: [PATCH fixup v1] of: base: register DT root as device

[Ahmad Fatoum <a.fatoum@pengutronix.de>]

Hi,

On 8/12/20 6:11 PM, Oleksij Rempel wrote:
>>> dt is used to make clear: it is root of dt and not some random root of
>>> what ever.
>>
>> It's redundant, there is already a .of suffix.
>> I like machine.of more though.

Makes me think. If we have a top level "dt-root" node,
won't this clash?


>> Do you have any examples of oftree resources for the root node?
> 
> Do you have any example of the root node used as device?

I am asking about an example of this particular usage in the root node
in device tree sources or bindings. You are asking about handling of the
device tree root node in the barebox device/driver model.

I don't see how that addresses my question.

>> I'd rather not litter core code with an if-clause that evaluates to
>> true only once,
> 
> How many ifs are added in this patch and how many ifs will by added by
> your suggestion? 

Mine adds none.

>> to support your (IMHO wrong)  use of a helper.
> 
> Interesting change of conversation. Please stay technical.

My technical opinion is that the helper is wrongly used.

>> of_device_make_bus_id is taken from Linux and does per comment:
>>
>> This routine will first try using the translated bus address to
>> derive a unique name. If it cannot, then it will prepend names from
>> parent nodes until a unique name can be derived.
>>
>> IMO, it should stay that way.
> 
> Ok, i'll send a patch to rename of_device_make_bus_id to of_device_make_id.
> In this case it will reflect new reality and keep the code readable.
> 
> If you have arguments in following topics:
> - it will significantly affect performance
> - it will affect size of executable
> - it will affect maintainability
> 
> Please use them

Shouldn't you be the one who argues in favor of his code?

It's ultimately Sascha's choice what to merge. To me this is
poor code, check my previous arguments.

Cheers,
Ahmad

> 
> Regards,
> Oleksij
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox