Re: [PATCH v4 06/16] crypto/Makefile: Drop unnecessary dependencies

[Ahmad Fatoum <a.fatoum@pengutronix.de>]

On 13.09.24 09:59, Sascha Hauer wrote:
> Having rsa-keys.h depend on the input key files is unnecessary. They
> were introduced to avoid unnecessary rebuilds when the files didn't
> change. This is unnecessary because the public_keys cmd won't produce
> output when it wouldn't change the existing file.
> 
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

Reviewed-by: Ahmad Fatoum <a.fatoum@pengutronix.de>

> ---
>  crypto/Makefile | 6 +-----
>  1 file changed, 1 insertion(+), 5 deletions(-)
> 
> diff --git a/crypto/Makefile b/crypto/Makefile
> index d7a06a721d..5a484355f3 100644
> --- a/crypto/Makefile
> +++ b/crypto/Makefile
> @@ -29,10 +29,6 @@ $(obj)/rsa.o: $(obj)/rsa-keys.h
>  
>  CONFIG_CRYPTO_RSA_KEY := $(CONFIG_CRYPTO_RSA_KEY:"%"=%)
>  
> -ifneq ($(filter-out pkcs11:% __ENV__%, $(CONFIG_CRYPTO_RSA_KEY)),)
> -RSA_DEP := $(CONFIG_CRYPTO_RSA_KEY)
> -endif
> -
> -$(obj)/rsa-keys.h: $(RSA_DEP) FORCE
> +$(obj)/rsa-keys.h: FORCE
>  	$(call cmd,public_keys,$(CONFIG_CRYPTO_RSA_KEY_NAME_HINT):$(CONFIG_CRYPTO_RSA_KEY))
>  endif


-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |