From: Nikita Yushchenko <nikita.yoush@cogentembedded.com>
To: Andrey Smirnov <andrew.smirnov@gmail.com>, barebox@lists.infradead.org
Cc: cphealy@gmail.com
Subject: Re: [PATCH] clk: i.MX51: Add missing USBOH3_GATE clock
Date: Tue, 23 May 2017 08:42:09 +0300 [thread overview]
Message-ID: <99117b21-0d83-87ab-e196-1e02e0df6601@cogentembedded.com> (raw)
In-Reply-To: <20170522152213.14028-1-andrew.smirnov@gmail.com>
> static void mx5_clocks_mx51_mx53_init(void __iomem *base)
> @@ -392,6 +394,12 @@ int __init mx51_clocks_init(struct device_d *dev, void __iomem *regs)
> clkdev_add_physbase(clks[IMX5_CLK_PER_ROOT], MX51_PWM1_BASE_ADDR, "per");
> clkdev_add_physbase(clks[IMX5_CLK_PER_ROOT], MX51_PWM2_BASE_ADDR, "per");
>
> + clkdev_add_physbase(clks[IMX5_CLK_USBOH3_GATE], MX51_OTG_BASE_ADDR + 0x000, NULL);
> + clkdev_add_physbase(clks[IMX5_CLK_USBOH3_GATE], MX51_OTG_BASE_ADDR + 0x200, NULL);
> + clkdev_add_physbase(clks[IMX5_CLK_USBOH3_GATE], MX51_OTG_BASE_ADDR + 0x400, NULL);
> + clkdev_add_physbase(clks[IMX5_CLK_USBOH3_GATE], MX51_OTG_BASE_ADDR + 0x600, NULL);
> + clkdev_add_physbase(clks[IMX5_CLK_USBOH3_GATE], MX51_OTG_BASE_ADDR + 0x800, NULL);
> +
> if (IS_ENABLED(CONFIG_DRIVER_VIDEO_IMX_IPUV3))
> mx51_clocks_ipu_init(regs);
It may be cleaner to setup USB related clocks under
if (IS_ENABLED(CONFIG_...) { ... } - i.e. in the same way as IPU
related clocks are added in neighbour line.
Also, this is the only place in this file where address arithmetic is
used. Not sure if this is ok or not but it catches eye.
Nikita
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2017-05-23 5:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-22 15:22 Andrey Smirnov
2017-05-23 5:42 ` Nikita Yushchenko [this message]
2017-05-24 4:43 ` Andrey Smirnov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=99117b21-0d83-87ab-e196-1e02e0df6601@cogentembedded.com \
--to=nikita.yoush@cogentembedded.com \
--cc=andrew.smirnov@gmail.com \
--cc=barebox@lists.infradead.org \
--cc=cphealy@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox