mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: Bastian Krause <bst@pengutronix.de>, barebox@lists.infradead.org
Subject: Re: [PATCH] ARM: riotboard: add habv4-imx6-gencsf.h to flash header
Date: Thu, 31 Jul 2025 11:08:52 +0200	[thread overview]
Message-ID: <9aa2f3c3-0c82-4dfa-94b9-226e696a433a@pengutronix.de> (raw)
In-Reply-To: <20250710090644.280957-1-bst@pengutronix.de>

Hi Bastian,

On 7/10/25 11:06, Bastian Krause wrote:
> The header is necessary to add CSF data for signed barebox images in
> case HABV4_IMAGE_SIGNED=y is set. It should not hurt otherwise.

If it doesn't hurt, what do you think of having the build system include
it everywhere unconditionally?

> Signed-off-by: Bastian Krause <bst@pengutronix.de>

Reviewed-by: Ahmad Fatoum <a.fatoum@pengutronix.de>

Cheers,
Ahmad

> ---
>  .../embest-riotboard/flash-header-embest-riotboard.imxcfg       | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arch/arm/boards/embest-riotboard/flash-header-embest-riotboard.imxcfg b/arch/arm/boards/embest-riotboard/flash-header-embest-riotboard.imxcfg
> index 5464e2461d0..1f27163417f 100644
> --- a/arch/arm/boards/embest-riotboard/flash-header-embest-riotboard.imxcfg
> +++ b/arch/arm/boards/embest-riotboard/flash-header-embest-riotboard.imxcfg
> @@ -66,3 +66,5 @@ wm 32 MX6_MMDC_P0_MPODTCTRL 0x00011117
>  wm 32 MX6_MMDC_P0_MDPDC 0x00025565
>  wm 32 MX6_MMDC_P0_MAPSR 0x00011006
>  wm 32 MX6_MMDC_P0_MDSCR 0x00000000
> +
> +#include <mach/imx/habv4-imx6-gencsf.h>

-- 
Pengutronix e.K.                  |                             |
Steuerwalder Str. 21              | http://www.pengutronix.de/  |
31137 Hildesheim, Germany         | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686  | Fax:   +49-5121-206917-5555 |




  reply	other threads:[~2025-07-31  9:09 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-10  9:06 Bastian Krause
2025-07-31  9:08 ` Ahmad Fatoum [this message]
2025-07-31  9:36   ` Bastian Krause
2025-08-05  9:22 ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9aa2f3c3-0c82-4dfa-94b9-226e696a433a@pengutronix.de \
    --to=a.fatoum@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=bst@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox