From: Jonas Rebmann <jre@pengutronix.de>
To: Ahmad Fatoum <a.fatoum@pengutronix.de>,
Sascha Hauer <s.hauer@pengutronix.de>,
BAREBOX <barebox@lists.infradead.org>
Cc: Tobias Waldekranz <tobias@waldekranz.com>
Subject: Re: [PATCH v2 9/9] test: py: add TLV integration tests
Date: Mon, 13 Oct 2025 12:53:32 +0200 [thread overview]
Message-ID: <9b501658-ec62-4bf8-9581-eedb8fcd180f@pengutronix.de> (raw)
In-Reply-To: <79020d0a-53ab-48b5-a43a-1e4584700e1e@pengutronix.de>
Hi Ahmad,
On 2025-10-13 12:35, Ahmad Fatoum wrote:
> On 10/7/25 11:12 AM, Ahmad Fatoum wrote:
>>> +from crcmod.predefined import mkPredefinedCrcFun
>>> +from .helper import skip_disabled
>>> +
>>> +_crc32_mpeg = mkPredefinedCrcFun("crc-32-mpeg")
>
> This is unused, what's the point?
>
> I will submit a patch for removal.
This indeed made it into my patch by mistake. It was supposed to be part
of the upcoming TLV signature integration tests in test/py/tset_tlv.py,
which I'll send this week.
There, I have tests with invalid signatures and valid CRCs for which I
need to fix CRCs after modifying the TLVs; hence the need for
_crc32_mpeg (which we also use in bareboxtlv-generator.py).
Regards,
Jonas
--
Pengutronix e.K. | Jonas Rebmann |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-9 |
next prev parent reply other threads:[~2025-10-13 10:54 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-29 8:03 [PATCH v2 0/9] TLV integration tests and test/py cleanup Jonas Rebmann
2025-09-29 8:03 ` [PATCH v2 1/9] test: when testfs feature is available, always enable it Jonas Rebmann
2025-10-07 9:07 ` Ahmad Fatoum
2025-09-29 8:03 ` [PATCH v2 2/9] test: provide testfs via fixture Jonas Rebmann
2025-10-07 9:08 ` Ahmad Fatoum
2025-09-29 8:03 ` [PATCH v2 3/9] test: move dm-verity testdata generation to fixture Jonas Rebmann
2025-10-07 9:09 ` Ahmad Fatoum
2025-09-29 8:03 ` [PATCH v2 4/9] test: move fitimage testdata generation to fixture and drop script Jonas Rebmann
2025-10-07 9:09 ` Ahmad Fatoum
2025-09-29 8:03 ` [PATCH v2 5/9] test: py: test_bootchooser: remove dead code Jonas Rebmann
2025-10-07 9:10 ` Ahmad Fatoum
2025-09-29 8:03 ` [PATCH v2 6/9] commands: tlv: clarify error opening tlv Jonas Rebmann
2025-10-07 9:11 ` Ahmad Fatoum
2025-09-29 8:03 ` [PATCH v2 7/9] ci: container: install crcmod and cryptography Jonas Rebmann
2025-10-07 9:11 ` Ahmad Fatoum
2025-09-29 8:03 ` [PATCH v2 8/9] configs: enable tlv command for multi_v7 and multi_v8 Jonas Rebmann
2025-10-07 9:12 ` Ahmad Fatoum
2025-09-29 8:04 ` [PATCH v2 9/9] test: py: add TLV integration tests Jonas Rebmann
2025-10-07 9:12 ` Ahmad Fatoum
2025-10-13 10:35 ` Ahmad Fatoum
2025-10-13 10:53 ` Jonas Rebmann [this message]
2025-10-07 9:37 ` [PATCH v2 0/9] TLV integration tests and test/py cleanup Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9b501658-ec62-4bf8-9581-eedb8fcd180f@pengutronix.de \
--to=jre@pengutronix.de \
--cc=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=s.hauer@pengutronix.de \
--cc=tobias@waldekranz.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox