mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: Robert Karszniewicz <r.karszniewicz@phytec.de>,
	barebox@lists.infradead.org
Subject: Re: [PATCH] sandbox: add_image: mmap block devices
Date: Thu, 24 Oct 2019 18:07:12 +0200	[thread overview]
Message-ID: <9bc4633e-6f71-0c6c-988c-e8a1e11e713a@pengutronix.de> (raw)
In-Reply-To: <1571932955-98554-1-git-send-email-r.karszniewicz@phytec.de>

On 10/24/19 6:02 PM, Robert Karszniewicz wrote:
> This makes it possible to mount block devices from the host machine,
> which have been passed as arguments to --image
> 
> Signed-off-by: Robert Karszniewicz <r.karszniewicz@phytec.de>
> ---
>  arch/sandbox/os/common.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/arch/sandbox/os/common.c b/arch/sandbox/os/common.c
> index 86118822a..805ac8eef 100644
> --- a/arch/sandbox/os/common.c
> +++ b/arch/sandbox/os/common.c
> @@ -39,6 +39,8 @@
>  #include <signal.h>
>  #include <sys/select.h>
>  #include <sys/wait.h>
> +#include <sys/ioctl.h>
> +#include <linux/fs.h>
>  /*
>   * ...except the ones needed to connect with barebox
>   */
> @@ -260,6 +262,12 @@ static int add_image(char *str, char *devname_template, int *devname_number)
>  	hf->size = s.st_size;
>  	hf->devname = strdup(devname);
>  
> +	if (S_ISBLK(s.st_mode)) {
> +		if (-1 == ioctl(fd, BLKGETSIZE64, &hf->size)) {

This looks out of place for barebox, the -1 should be on the right side.

> +			perror("ioctl");
> +			goto err_out;
> +		}
> +	}
>  	hf->base = (unsigned long)mmap(NULL, hf->size,
>  			PROT_READ | (readonly ? 0 : PROT_WRITE),
>  			MAP_SHARED, fd, 0);
> 


-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2019-10-24 16:07 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-24 16:02 Robert Karszniewicz
2019-10-24 16:07 ` Ahmad Fatoum [this message]
2019-10-25 11:08   ` Robert Karszniewicz
2019-10-25 11:19   ` [PATCH v2] " Robert Karszniewicz
2019-10-28 11:44     ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9bc4633e-6f71-0c6c-988c-e8a1e11e713a@pengutronix.de \
    --to=a.fatoum@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=r.karszniewicz@phytec.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox