From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Tue, 02 Jun 2026 14:14:33 +0200 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wUO0v-001Zte-13 for lore@lore.pengutronix.de; Tue, 02 Jun 2026 14:14:33 +0200 Received: from bombadil.infradead.org ([2607:7c80:54:3::133]) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1wUO0u-0005BA-JR for lore@pengutronix.de; Tue, 02 Jun 2026 14:14:33 +0200 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version: Content-Transfer-Encoding:Content-Type:References:In-Reply-To:Date:Cc:To:From :Subject:Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=d/iSZ1v6NJwVQrWlbKegxSFMYXjI1UwfP50BJ2e1pHU=; b=xsFRNBtyCJkLJXSLnopOBcGtW4 O7YpkNjGLmBNB7gdxGjCAEvoV3mGXe0cei7pKA0L8z4vMaAKzaH6Wt8o93Xsg3FRGg1LVKlfq3Fm2 GeCq/Ov3gZKs44oKFylhos02XGrty9yM+eXDlee2cER+wlamTxPspmIh9GUNUay38adbEgInCplC7 UeYPqlmN+0F8IlqQpiUo0+5oxc3AejAazGQmYC59x2gVuPPBsLRnfvzu7DWb5/K5GG2MzDJJvJ+0G LPGBmS698TyDpHjYz4sc8wUSihlTE8SUuscv/fPWb1nnmDiqQb//qOuD4kEvs2BULWnSPKvNvh/pd LzL438Sw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wUNzF-0000000Cwyb-06eS; Tue, 02 Jun 2026 12:12:49 +0000 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wUNzC-0000000Cwy5-2GgT for barebox@lists.infradead.org; Tue, 02 Jun 2026 12:12:48 +0000 Received: from ptz.office.stw.pengutronix.de ([2a0a:edc0:0:900:1d::77] helo=[IPv6:::1]) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1wUNzA-0004ns-6q; Tue, 02 Jun 2026 14:12:44 +0200 Message-ID: <9bf1b5920ca2c986533c5f17d10aa774aa60c895.camel@pengutronix.de> From: Lucas Stach To: Ahmad Fatoum , Johannes Schneider , barebox@lists.infradead.org Cc: thomas.haemmerle@leica-geosystems.com Date: Tue, 02 Jun 2026 14:12:43 +0200 In-Reply-To: <679f1823-5edd-4a8f-8a8e-caf6db7dd483@pengutronix.de> References: <20260602040953.1060278-1-johannes.schneider@leica-geosystems.com> <20260602040953.1060278-7-johannes.schneider@leica-geosystems.com> <54467182b9e4f15a1ac068533e73aaac5f21bf46.camel@pengutronix.de> <679f1823-5edd-4a8f-8a8e-caf6db7dd483@pengutronix.de> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.60.1 (3.60.1-1.fc44) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260602_051246_585892_DDB410F0 X-CRM114-Status: GOOD ( 30.76 ) X-BeenThere: barebox@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "barebox" X-SA-Exim-Connect-IP: 2607:7c80:54:3::133 X-SA-Exim-Mail-From: barebox-bounces+lore=pengutronix.de@lists.infradead.org X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.whiteo.stw.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-4.8 required=4.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.2 Subject: Re: [PATCH 6/6] video: imx-lcdif: drain write-combine buffer before LCDIF DMA reads pixels X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on metis.whiteo.stw.pengutronix.de) Am Dienstag, dem 02.06.2026 um 11:37 +0200 schrieb Ahmad Fatoum: >=20 > On 6/2/26 10:12 AM, Lucas Stach wrote: > > Am Dienstag, dem 02.06.2026 um 04:09 +0000 schrieb Johannes Schneider: > > > From: Thomas Haemmerle > > >=20 > > > The LCDIF framebuffer is allocated as Normal Non-Cacheable (write-com= bine) > > > memory. After the splash command calls gu_screen_blit(), which copie= s the > > > decoded PNG via memcpy() from a cached shadow buffer into the hardwar= e > > > framebuffer, writes may still reside in the CPU write buffer and not = yet > > > be visible to the LCDIF DMA engine. On hardware this manifests as > > > partial or corrupted rendering =E2=80=94 the bottom portion of the sp= lash image > > > renders black or shows garbage. > > >=20 > > > Implement fb_damage() to execute a DSB SY barrier after each blit, > > > ensuring all pending write-combine writes are committed to DRAM befor= e > > > the LCDIF reads the pixel data. > > >=20 > > > Assisted-by: Claude:claude-sonnet-4-6 > > > Signed-of-by: Thomas Haemmerle > > > --- > > > drivers/video/imx-lcdif.c | 13 +++++++++++++ > > > 1 file changed, 13 insertions(+) > > >=20 > > > diff --git a/drivers/video/imx-lcdif.c b/drivers/video/imx-lcdif.c > > > index ae5976c771..8d9b40be0f 100644 > > > --- a/drivers/video/imx-lcdif.c > > > +++ b/drivers/video/imx-lcdif.c > > > @@ -20,6 +20,7 @@ > > > #include > > > #include