mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: Sascha Hauer <sha@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] of: platform: don't fail of_find_device_by_node() if no driver bound
Date: Thu, 5 Oct 2023 08:53:15 +0200	[thread overview]
Message-ID: <9d7b22f9-ee56-6ab2-c193-4f2b8e02fa39@pengutronix.de> (raw)
In-Reply-To: <20230926113853.GC637806@pengutronix.de>

Hello Sascha,

On 26.09.23 13:38, Sascha Hauer wrote:
> On Thu, Sep 14, 2023 at 09:30:18AM +0200, Ahmad Fatoum wrote:
>> of_find_device_by_node() may be called by a driver following
>> of_platform_populate in order to bind the children to drivers.
>> It's thus wrong to return NULL when a device has been found, but no
>> driver was registered. That also aligns the function with the
>> expectation resulting from its name: A device is found and devices may
>> be bound or not.
> 
> I hesitated applying this one because I am not sure if some users expect
> to have a driver bound when of_find_device_by_node() returns a valid
> pointer.
> 
> I applied it now, let's see what happens.

I ran into this porting the CAAM driver to work on i.MX8M. I don't know
if existing drivers are affected, but it's the correct thing to do.

> 
> Sascha
> 
>>
>> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
>> ---
>>  drivers/of/platform.c | 6 ++----
>>  1 file changed, 2 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/of/platform.c b/drivers/of/platform.c
>> index bd5f2ad82c6b..1f79a539f541 100644
>> --- a/drivers/of/platform.c
>> +++ b/drivers/of/platform.c
>> @@ -23,11 +23,9 @@
>>  struct device *of_find_device_by_node(struct device_node *np)
>>  {
>>  	struct device *dev;
>> -	int ret;
>>  
>> -	ret = of_device_ensure_probed(np);
>> -	if (ret)
>> -		return NULL;
>> +	/* Not having a driver is not an error here */
>> +	(void)of_device_ensure_probed(np);
>>  
>>  	if (deep_probe_is_supported())
>>  		return np->dev;
>> -- 
>> 2.39.2
>>
>>
>>
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |




      reply	other threads:[~2023-10-05  6:54 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-14  7:30 Ahmad Fatoum
2023-09-26 11:38 ` Sascha Hauer
2023-10-05  6:53   ` Ahmad Fatoum [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9d7b22f9-ee56-6ab2-c193-4f2b8e02fa39@pengutronix.de \
    --to=a.fatoum@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=sha@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox