Re: [PATCH 1/2] imx-bbu-nand-fcb: do not use hardcoded devicefile

[Ahmad Fatoum <a.fatoum@pengutronix.de>]

On 04.03.25 18:49, Stefano Manni wrote:
> 
> 
> Hello Ahmad,
> 
> On lun, mar 3 2025 at 09:41:53 +01:00:00, Ahmad Fatoum <a.fatoum@pengutronix.de> wrote:
>> On 24.02.25 16:49, Stefano Manni wrote:
>>>  Hello Ahmad,
>>>
>>>  On ven, feb 21 2025 at 18:33:04 +01:00:00, Ahmad Fatoum <a.fatoum@pengutronix.de> wrote:
>>>>  Hello Stefano,
>>>>
>>>>  On 21.02.25 19:01, Stefano Manni wrote:
>>>>>   Device file was hardcoded to "nand0.barebox".
>>>>>   This patch harmonize the signature of
>>>>>
>>>>>   imx6_bbu_nand_register_handler()
>>>>>   imx7_bbu_nand_register_handler()
>>>>>   imx28_bbu_nand_register_handler()
>>>>>
>>>>>   with the other bbu register functions in order to take
>>>>>   the devicefile as parameter.
>>>>
>>>>  Is this this the sole motivation behind the patch or do you
>>>>  intend to actually make use of the ability of varying
>>>>  the devicefile?
>>>
>>>  my purpose is to let people use a device/partition different from the hardcoded one.
>>
>> Can you have multiple NANDs? But yes, customizing partition name can
>> be useful.
>>
> 
> for sure I cannot have multiple NANDs but I can have a different partition name.
> 
> Anyway drop the patch if you consider it not necessary.

I think the patch is ok.

Cheers,
Ahmad

> 
> Best,
> Stefano
> 
>> Thanks,
>> Ahmad
> 
> 
> 


-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |