Fwd: [PATCH 00/54] New arch (NIOS2)

[Franck JULLIEN <franck.jullien@gmail.com>]

[-- Attachment #1.1: Type: text/plain, Size: 2419 bytes --]

---------- Forwarded message ----------
From: Franck JULLIEN <franck.jullien@gmail.com>
Date: 2011/3/4
Subject: Re: [PATCH 00/54] New arch (NIOS2)
To: Sascha Hauer <s.hauer@pengutronix.de>


2011/3/4 Sascha Hauer <s.hauer@pengutronix.de>

> Hi Franck,
>
> On Thu, Mar 03, 2011 at 11:58:14PM +0100, franck.jullien@gmail.com wrote:
> > From: Franck JULLIEN <franck.jullien@gmail.com>
> >
> > This is the base files of the Nios2 port. Almost everything is comming
> from u-boot.
> > When those files are acked, I'll post drivers and utility commands.
>
> Soo many patches ;). You can safely combine all these into two
> patches, one for the nios2 support and one for the generic board.
> The patches are only useful as a whole anyway, so no need to split
> them up that fine. You will hit the list limit, so give me some time
> to go to the moderator interface and and it through.
>
> I'm not through all patches, but some remarks here:
>
> There is some whitespace damage all around like spaces which should be
> tabs.


Is that a "Linux rule" ? Is there other ones ? (I always convert tabs to
whitespaces....).


> Also, please do not use direct pointer derefs to access registers.
> You should use readl/writel accessors for them.
>
>
Okay I will.


> Thanks for doing this work. Although I don't have a nios baord, I really
> appreciate extending barebox to more architectures.
>

Barebox is so much better than Uboot, you guys did a really good job.
Barebox
even helped my to understand some Linux concepts.


>
> Sascha
>
>
Hi Sasha,

I didn't how to split the patches so I splitted everything :) I'll fight
with git to revert my commits and do it again...

This port is working but it's going to be a long process including it in
barebox git because I don't have a lot of time
(my baby boy needs my time) and I'm not a git master at all, I'm just an
hardware guy playing with the kernel (why the
hell it is so complicated ? I think it is kind of a filter/test for
patchers. If you can't use git you can't send patches ;)).

Souldn't be less complicated if I had a separate branch to work on it ?


> --
>
> Pengutronix e.K.                           |                             |
> Industrial Linux Solutions                 | http://www.pengutronix.de/  |
> Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
> Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
>

[-- Attachment #1.2: Type: text/html, Size: 4127 bytes --]

[-- Attachment #2: Type: text/plain, Size: 149 bytes --]

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox