From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-ew0-f49.google.com ([209.85.215.49]) by canuck.infradead.org with esmtps (Exim 4.72 #1 (Red Hat Linux)) id 1PvQw6-0007RZ-Cf for barebox@lists.infradead.org; Fri, 04 Mar 2011 09:04:35 +0000 Received: by ewy23 with SMTP id 23so633166ewy.36 for ; Fri, 04 Mar 2011 01:04:32 -0800 (PST) MIME-Version: 1.0 In-Reply-To: References: <4d701d2f.9009d80a.2cd3.5e70@mx.google.com> <20110304084533.GD29521@pengutronix.de> Date: Fri, 4 Mar 2011 10:04:31 +0100 Message-ID: From: Franck JULLIEN List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============0230984092==" Sender: barebox-bounces@lists.infradead.org Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Fwd: [PATCH 00/54] New arch (NIOS2) To: barebox --===============0230984092== Content-Type: multipart/alternative; boundary=0015174bf06c277c3c049da46f1b --0015174bf06c277c3c049da46f1b Content-Type: text/plain; charset=ISO-8859-1 ---------- Forwarded message ---------- From: Franck JULLIEN Date: 2011/3/4 Subject: Re: [PATCH 00/54] New arch (NIOS2) To: Sascha Hauer 2011/3/4 Sascha Hauer > Hi Franck, > > On Thu, Mar 03, 2011 at 11:58:14PM +0100, franck.jullien@gmail.com wrote: > > From: Franck JULLIEN > > > > This is the base files of the Nios2 port. Almost everything is comming > from u-boot. > > When those files are acked, I'll post drivers and utility commands. > > Soo many patches ;). You can safely combine all these into two > patches, one for the nios2 support and one for the generic board. > The patches are only useful as a whole anyway, so no need to split > them up that fine. You will hit the list limit, so give me some time > to go to the moderator interface and and it through. > > I'm not through all patches, but some remarks here: > > There is some whitespace damage all around like spaces which should be > tabs. Is that a "Linux rule" ? Is there other ones ? (I always convert tabs to whitespaces....). > Also, please do not use direct pointer derefs to access registers. > You should use readl/writel accessors for them. > > Okay I will. > Thanks for doing this work. Although I don't have a nios baord, I really > appreciate extending barebox to more architectures. > Barebox is so much better than Uboot, you guys did a really good job. Barebox even helped my to understand some Linux concepts. > > Sascha > > Hi Sasha, I didn't how to split the patches so I splitted everything :) I'll fight with git to revert my commits and do it again... This port is working but it's going to be a long process including it in barebox git because I don't have a lot of time (my baby boy needs my time) and I'm not a git master at all, I'm just an hardware guy playing with the kernel (why the hell it is so complicated ? I think it is kind of a filter/test for patchers. If you can't use git you can't send patches ;)). Souldn't be less complicated if I had a separate branch to work on it ? > -- > > Pengutronix e.K. | | > Industrial Linux Solutions | http://www.pengutronix.de/ | > Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | > Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | > --0015174bf06c277c3c049da46f1b Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable

---------- Forwarded message ----------<= br>From: Franck JULLIEN <franck.jullien@gmail.com>
Date: 2011/3/4
Subject: Re: [PATCH 00/54] New arch (NIOS2)
To: Sascha= Hauer <s.hauer@pengutronix.de= >


2011/3/4 Sascha Hauer <s.hauer@pengutronix.d= e>
Hi Franck,

On Thu, Mar 03, 2011 at 11:58:14PM +0100, franck.jullien@gmail.com wrote:
> From: Franck JULLIEN <franck.jullien@gmail.com>
>
> This is the base files of the Nios2 port. Almost everything is comming= from u-boot.
> When those files are acked, I'll post drivers and utility commands= .

Soo many patches ;). You can safely combine all these into two
patches, one for the nios2 support and one for the generic board.
The patches are only useful as a whole anyway, so no need to split
them up that fine. You will hit the list limit, so give me some time
to go to the moderator interface and and it through.

I'm not through all patches, but some remarks here:

There is some whitespace damage all around like spaces which should be
tabs.

Is that a "Linux rule"= ; ? Is there other ones ? (I always convert tabs to whitespaces....).
=
=A0
Also, please do not use direct pointer derefs to access registers.
You should use readl/writel accessors for them.


Okay I will.
=A0
Thanks for doing this work. Although I don't have a nios baord, I reall= y
appreciate extending barebox to more architectures.
Barebox is so much better than Uboot, you guys did a rea= lly good job. Barebox
even helped my to understand some Linux con= cepts.=A0
=A0

Sascha


Hi Sash= a,

I didn't how to split the patches so I splitted e= verything :) I'll fight with git to revert my commits and do it again..= .

This port is working but it's going to be a long pr= ocess including it in barebox git because I don't have a lot of time
(my baby boy needs my time) and I'm not a git master at all, I&= #39;m just an hardware guy playing with the kernel (why the=A0
hell it is so complicated ? I think it is kind=A0of a filter/test for = patchers. If you can't use git you can't send patches ;)).

Souldn't be less complicated if I had a separate branc= h to work on it ?
=A0
--

Pengutronix e.K. =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 | =A0 = =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 |
Industrial Linux Solutions =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 | http://www.pengutronix.de/ = =A0|
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 =A0 = =A0|
Amtsgericht Hildesheim, HRA 2686 =A0 =A0 =A0 =A0 =A0 | Fax: =A0 +49-5121-20= 6917-5555 |


--0015174bf06c277c3c049da46f1b-- --===============0230984092== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox --===============0230984092==--