[PATCH] Add a board specific fancy banner

[PATCH] Add a board specific fancy banner

[Franck JULLIEN]

[-- Attachment #1.1: Type: text/plain, Size: 1899 bytes --]

Hello,

This is the first time I'm using git and submit a patch so if I made a
mistake be cool :)
This is a small patch allowing the user to define a fancy banner for
barebox. I don't know
if you'll use it but it's kind of an experience for me.

I have ported barebox to the altera nios2 processor. I think I'll submit the
corresponding patch
on january. However, I'll need some advices to generate such a big (or lot
of small) patch.

Thanks,
Franck.

-----

from: franck JULLIEN <franck.jullien@gmail.com>
Date: Thu, 23 Dec 2010 22:31:22 +0100
Subject: [PATCH] Add a board specific fancy banner

---
 common/Kconfig   |    6 ++++++
 common/console.c |   10 ++++++++++
 2 files changed, 16 insertions(+), 0 deletions(-)

diff --git a/common/Kconfig b/common/Kconfig
index 617f640..d46c8fc 100644
--- a/common/Kconfig
+++ b/common/Kconfig
@@ -248,6 +248,12 @@ config HUSH_FANCY_PROMPT
   Allow to set PS1 from the command line. PS1 can have several escaped
commands
   like \h for CONFIG_BOARDINFO or \w for the current working directory.

+config BOARD_BANNER
+ bool
+ prompt "allow a board specific fancy banner"
+ help
+  Allow to define a custom board banner (you must define BOARD_BANNER in
your config.h)
+
 config HUSH_GETOPT
  bool
  depends on SHELL_HUSH
diff --git a/common/console.c b/common/console.c
index 82786f2..8a830e3 100644
--- a/common/console.c
+++ b/common/console.c
@@ -46,7 +46,17 @@ EXPORT_SYMBOL(console_list);
 static void display_banner (void)
 {
  printf (RELOC("\n\n%s\n\n"), RELOC_VAR(version_string));
+#ifdef CONFIG_BOARD_BANNER
+#ifdef BOARD_BANNER
+ printf(RELOC(BOARD_BANNER));
+#else
+#define VT100_YELLOW "\033[1;33m"
+#define VT100_RESET "\033[1;0m"
+ printf(RELOC("Board: " VT100_YELLOW CONFIG_BOARDINFO VT100_RESET "\n"));
+#endif
+#else
  printf(RELOC("Board: " CONFIG_BOARDINFO "\n"));
+#endif
 }

 static int __early_initdata initialized = 0;
-- 
1.7.0.4

[-- Attachment #1.2: Type: text/html, Size: 3615 bytes --]

[-- Attachment #2: Type: text/plain, Size: 149 bytes --]

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH] Add a board specific fancy banner

[Jean-Christophe PLAGNIOL-VILLARD]

On 22:42 Thu 23 Dec     , Franck JULLIEN wrote:
>    Hello,
>    This is the first time I'm using git and submit a patch so if I made a
>    mistake be cool :)
>    This is a small patch allowing the user to define a fancy banner for
>    barebox. I don't know
>    if you'll use it but it's kind of an experience for me.
>    I have ported barebox to the altera nios2 processor. I think I'll submit
>    the corresponding patch
>    on january. However, I'll need some advices to generate such a big (or lot
>    of small) patch.
It will be better to do it via Kconfig and avoid the ifdef

for the nios2 it will be better to spit it in small patch than a big one

Best Regards,
J.

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH] Add a board specific fancy banner

[Uwe Kleine-König]

Hello Franck,

On Thu, Dec 23, 2010 at 10:42:34PM +0100, Franck JULLIEN wrote:
> This is the first time I'm using git and submit a patch so if I made a
> mistake be cool :)
:-)

>  common/Kconfig   |    6 ++++++
>  common/console.c |   10 ++++++++++
>  2 files changed, 16 insertions(+), 0 deletions(-)
> 
> diff --git a/common/Kconfig b/common/Kconfig
> index 617f640..d46c8fc 100644
> --- a/common/Kconfig
> +++ b/common/Kconfig
> @@ -248,6 +248,12 @@ config HUSH_FANCY_PROMPT
>    Allow to set PS1 from the command line. PS1 can have several escaped
> commands
>    like \h for CONFIG_BOARDINFO or \w for the current working directory.
> 
> +config BOARD_BANNER
> + bool
> + prompt "allow a board specific fancy banner"
> + help
> +  Allow to define a custom board banner (you must define BOARD_BANNER in
> your config.h)
Your patch is line broken, which makes is unapplicable.  I don't know
which MUA you're using, but you either should use git send-email or take
a look into

	http://git.kernel.org/?p=git/git.git;a=blob;f=Documentation/SubmittingPatches;h=72741ebda12de8fbf786f12531d70ab465eecf42;hb=HEAD#l333

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox