From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-ew0-f49.google.com ([209.85.215.49]) by canuck.infradead.org with esmtp (Exim 4.72 #1 (Red Hat Linux)) id 1PZqIH-0002Z6-5K for barebox@lists.infradead.org; Mon, 03 Jan 2011 19:42:14 +0000 Received: by ewy20 with SMTP id 20so5820452ewy.36 for ; Mon, 03 Jan 2011 11:42:11 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <20110103135058.GB24408@pengutronix.de> References: <20101230034811.GS19266@game.jcrosoft.org> <1293713374-3476-1-git-send-email-franck.jullien@gmail.com> <20110103114144.GL6017@pengutronix.de> <20110103135058.GB24408@pengutronix.de> Date: Mon, 3 Jan 2011 20:42:11 +0100 Message-ID: From: Franck JULLIEN List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============1844996648==" Sender: barebox-bounces@lists.infradead.org Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH] Add an option to set a board specific banner To: Sascha Hauer Cc: barebox@lists.infradead.org --===============1844996648== Content-Type: multipart/alternative; boundary=0015174be8c41e090f0498f65983 --0015174be8c41e090f0498f65983 Content-Type: text/plain; charset=ISO-8859-1 2011/1/3 Sascha Hauer > On Mon, Jan 03, 2011 at 01:45:18PM +0100, Franck JULLIEN wrote: > > 2011/1/3 Sascha Hauer > > > > > > I know CONFIG_BOARDINFO is board specific. However, I think it is more > > conveniant > > to have the possibility to define a banner text outside the Kconfig. For > > example, I use > > this in my config.h: > > > > #define CONFIG_BOARD_BANNER_TEXT "\e[1;32m\ > > > ***********************************************************************\n\ > > * Communication board bootloader (ODSFT0152) *\n\ > > ************************************************************************\ > > \e[0m\n\n" > > > > So may be we could define this kind of banner in the Kconfig..... > > Ok, I can see your problem. I think we should rather define a board > specific function to display a banner than a string, so something like: > > config BOARD_BANNER > bool > > #ifdef CONFIG_BOARD_BANNER > display_board_banner(); > #else > printf(RELOC("Board: " CONFIG_BOARDINFO "\n")); > #endif > > This way we can also show runtime dependent information in the banner > (like baseboard or whatever). > Sounds great, I'll do this. Is there anyone responsible for the list in first place ? Because if I do this in one way but someone would prefer do it another way and finally the git boss wants it a third way....... I'll try to post the new patch in response to this thread using the right git command...By the way, I there anything more user friendly than the git command line to send email in the right format ? I told you this is a practice/test patch so I have a lot of questions/comments ! > > > > > Let me know if you don't like this. This patch was kind of a test for me > and > > we could > > forget about it. > > > > Although this patch was very small, we had a lot of discussion around it > and > > I don't want to imagine what it is going to be when I submit the nios2 > port :) > > Don't worry, the amount of comments you receive usually is not > proportional to the patch size you send ;) > > Sascha > Ok, because I was worry :) > > -- > Pengutronix e.K. | | > Industrial Linux Solutions | http://www.pengutronix.de/ | > Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | > Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | > Best regards, FJ. --0015174be8c41e090f0498f65983 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable

2011/1/3 Sascha Hauer = <s.hauer@pengutronix.de>= ;
On Mon, Jan 03, 2011 at 01:45:18PM +0100, Franck JULLIEN = wrote:
> 2011/1/3 Sascha Hauer <s.= hauer@pengutronix.de>
>
>
> I know CONFIG_BOARDINFO is board specific. How= ever, I think it is more
> conveniant
> to have the possibility to define a banner text outside the Kconfig. F= or
> example, I use
> this in my config.h:
>
> #define CONFIG_BOARD_BANNER_TEXT "\e[1;32m\
> **********************************************************************= *\n\
> * =A0 =A0 =A0 =A0 =A0 Communication board bootloader (ODSFT0152) =A0 = =A0 =A0 =A0*\n\
> **********************************************************************= **\
> \e[0m\n\n"
>
> So may be we could define this kind of banner in the Kconfig.....

Ok, I can see your problem. I think we should rather define a board specific function to display a banner than a string, so something like:

config BOARD_BANNER
=A0 =A0 =A0 =A0bool

#ifdef CONFIG_BOARD_BANNER
=A0 =A0 =A0 =A0display_board_banner();
#else
=A0 =A0 =A0 =A0printf(RELOC("Board: " CONFIG_B= OARDINFO "\n"));
#endif

This way we can also show runtime dependent information in the banner
(like baseboard or whatever).

Sounds great, I'll do this. Is= there anyone responsible for the list in first place ?
Because if I do this in one way but someone would prefer do it another= way and
finally=A0the git boss wants it a third way.......
=

I'll try to post the new patch in response to this = thread
using the right git command...By the way, I there anything more user f= riendly
than the git command line to send email in the right form= at ?

I told you this is a practice/test patch so I= have a lot of questions/comments !
=A0

>
> Let me know if you don't like this. This patch was kind of a test = for me and
> we could
> forget about it.
>
> Although this patch was very small, we had a lot of discussion around = it and
> I don't want to imagine what it is going to be when I submit the n= ios2 port :)

Don't worry, the amount of comments you receive usually is not proportional to the patch size you send ;)

Sascha

Ok, because I was worry :)
=A0

--
Pengutronix e.K. =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 | =A0 = =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 |
Industrial Linux Solutions =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 | http://www.pengutronix.de/ = =A0|
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 =A0 = =A0|
Amtsgericht Hildesheim, HRA 2686 =A0 =A0 =A0 =A0 =A0 | Fax: =A0 +49-5121-20= 6917-5555 |

Best regards,
FJ.=A0

--0015174be8c41e090f0498f65983-- --===============1844996648== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox --===============1844996648==--