mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Gaurav Singh <gausinghnsit@gmail.com>
To: Juergen Beisert <jbe@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: Failing to load Barebox Environment
Date: Wed, 29 Sep 2010 15:33:27 +0530	[thread overview]
Message-ID: <AANLkTikaqxk2_HrU_cBfr9Yni6T9LcB8rhO4yVDRw+CG@mail.gmail.com> (raw)
In-Reply-To: <201009291123.19306.jbe@pengutronix.de>

Just a question regarding the host generated environement file.

In common/environment.c - the host specific envfs_save function is setting

size = (unsigned long)data.writep;

Now there is no way of ensuring that the size is padded to Page size.
The script bareboxenv seems not to use the pad parameter to change the
size parameter of the ENVFS superblock.
Now I know that we can't issue read commands which are not multiples
of Page size. But this is exactly what we are doing in envfs_load:

size = ENVFS_32(super.size);
buf = xmalloc(size);
buf_free = buf;
ret = read(envfd, buf, size);

I think this explains why my read is failing !

Regards
Gaurav






On Wed, Sep 29, 2010 at 2:53 PM, Juergen Beisert <jbe@pengutronix.de> wrote:
> Juergen Beisert wrote:
>> Just a note:
>>
>> You configure:
>> > >> devfs_add_partition("nand0", 0x00000, 0x200000, PARTITION_FIXED,
>> > >> "self_raw"); dev_add_bb_dev("self_raw", "self0");
>> > >> devfs_add_partition("nand0", 0x200000, 0x200000, PARTITION_FIXED,
>> > >> "env_raw"); dev_add_bb_dev("env_raw", "env0");
>>
>> And then:
>> > EVB2065> addpart /dev/nand0 4M(barebox)ro,2M(kernel)ro,-(root)
>>
>> Both must match!
>>
>> Try instead:
>>
>> EVB2065> addpart /dev/nand0 256k(barebox)ro,256k(env),2M(kernel)ro,-(root)
>>
>> jbe
>
> Ups, sorry: 0x200000 != 256k (didn't count the '0' right...)
>
> EVB2065> addpart /dev/nand0 2M(barebox)ro,2M(env),2M(kernel)ro,-(root)
>
> jbe
>
> --
> Pengutronix e.K.                              | Juergen Beisert             |
> Linux Solutions for Science and Industry      | Phone: +49-8766-939 228     |
> Vertretung Sued/Muenchen, Germany             | Fax:   +49-5121-206917-5555 |
> Amtsgericht Hildesheim, HRA 2686              | http://www.pengutronix.de/  |
>

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2010-09-29 10:03 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-29  6:50 Gaurav Singh
2010-09-29  7:29 ` Juergen Beisert
2010-09-29  7:48 ` Sascha Hauer
2010-09-29  9:01   ` Gaurav Singh
2010-09-29  9:08     ` Juergen Beisert
2010-09-29  9:14       ` Gaurav Singh
2010-09-29  9:23       ` Juergen Beisert
2010-09-29 10:03         ` Gaurav Singh [this message]
2010-09-29 10:08           ` Gaurav Singh
2010-09-30  6:39         ` Gaurav Singh
2010-10-01 11:10           ` Gaurav Singh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AANLkTikaqxk2_HrU_cBfr9Yni6T9LcB8rhO4yVDRw+CG@mail.gmail.com \
    --to=gausinghnsit@gmail.com \
    --cc=barebox@lists.infradead.org \
    --cc=jbe@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox