mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Belisko Marek <marek.belisko@gmail.com>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCHv2] Add dynamic video initialization to barebox
Date: Thu, 18 Nov 2010 09:18:36 +0100	[thread overview]
Message-ID: <AANLkTimhJsC+aZYZsjVMkgTNDyQuAG1q+3LJaJVnJusV@mail.gmail.com> (raw)
In-Reply-To: <20101117084405.GR6017@pengutronix.de>

Hi,

On Wed, Nov 17, 2010 at 9:44 AM, Sascha Hauer <s.hauer@pengutronix.de> wrote:
> On Mon, Nov 15, 2010 at 11:25:53AM +0100, Belisko Marek wrote:
>> Hi,
>>
>> On Mon, Nov 15, 2010 at 10:57 AM, Juergen Beisert <jbe@pengutronix.de> wrote:
>> > Hi Sascha,
>> >
>> > Sascha Hauer wrote:
>> >> On Tue, Oct 26, 2010 at 01:31:36PM +0200, Juergen Beisert wrote:
>> >> > Currently barebox uses a fixed videomode setup. Everything is compiled
>> >> > in. This change adds the possibility to select a videomode according to a
>> >> > connected display at runtime. The current behaviour is still present if
>> >> > not otherwise configured. If configured for runtime setup, initialization
>> >> > of the video hardware will be delayed until the required videomode will
>> >> > be selected from the shell code. If more than one videomode is supported
>> >> > by the platform, running the 'devinfo' command on the framebuffer device
>> >> > shows the supported videomode list. After selecting the videomode, the
>> >> > output can be enabled.
>> >>
>> >> General remarks about this series:
>> >>
>> >> - Please do not add code with '#if 0' and activate it later. This shows
>> >>   the series has the wrong order.
>> >
>> > This was for review only. If I would change the code in one step, the patch is
>> > unreadable.
>> >
>> >> - Please refrain from basing your internal functions around 'struct
>> >>   device_d'. By doing so we completey lose type safety and at least in
>> >>   case of the mci framework where three different devices are involved
>> >>   this leads to unreadable and error prone code.
>> >
>> > But IMHO in the case of the MCI there _are_ three devices!
>> >  - The one that knows how to handle disk drives
>> >  - The one that knows what a SD card is
>> >  - the one that knows how to transfer data from an to an attached device.
>> >
>> > Why this is unreadable or error prone? If you combine all these different
>> > functions into one I would say: Yes, the result is unreadable and error
>> > prone. And if you would say for a bootloader this separate approach is
>> > over-engineered, I would say: Maybe.
>> >
>> >>   The framebuffer code should be based around struct fb_info.
>> >
>> > I do not like this idea, but okay. In the next series I will do it in this
>> > way.
>> >
>> >> - Please keep the line lengths within sensible limits.
>> >
>> > Sorry, I checked it the last time, but some lines are slipped through.
>> Couldn't be included in barebox scripts also checkpatch.pl script from kernel?
>> Would be nice to have proper patches with kernel coding style.
>
> Sure, send a patch ;)
Just checkpatch.pl from kernel or invent some less restrictive tool ;)
in e.g .python?
>
> Sascha
>
>
> --
> Pengutronix e.K.                           |                             |
> Industrial Linux Solutions                 | http://www.pengutronix.de/  |
> Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
> Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
>

marek

-- 
as simple and primitive as possible
-------------------------------------------------
Marek Belisko - OPEN-NANDRA
Freelance Developer

Ruska Nova Ves 219 | Presov, 08005 Slovak Republic
Tel: +421 915 052 184
skype: marekwhite
icq: 290551086
web: http://open-nandra.com

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2010-11-18  8:18 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-26 11:31 Juergen Beisert
2010-10-26 11:31 ` [PATCH 01/12] Separate framebuffer platformdata and the videomode Juergen Beisert
2010-10-26 11:31 ` [PATCH 02/12] Add more flags for sync control Juergen Beisert
2010-10-26 11:31 ` [PATCH 03/12] Bring in dynamic videomode selection at runtime Juergen Beisert
2010-11-01 13:47   ` Sascha Hauer
2010-11-15 10:04     ` Juergen Beisert
2010-11-17  8:27       ` Sascha Hauer
2010-11-01 14:16   ` Sascha Hauer
2010-11-15 10:08     ` Juergen Beisert
2010-10-26 11:31 ` [PATCH 04/12] Remove the old videomode functions Juergen Beisert
2010-10-26 11:31 ` [PATCH 05/12] Add verbose framebuffer device info Juergen Beisert
2010-10-26 11:31 ` [PATCH 06/12] Adapt the existing imx fb driver to support runtime videomode selection Juergen Beisert
2010-10-26 11:31 ` [PATCH 07/12] Adapt the existing imx-ipu " Juergen Beisert
2010-10-26 11:31 ` [PATCH 08/12] Add a video driver for S3C2440 bases platforms Juergen Beisert
2010-11-01 14:41   ` Sascha Hauer
2010-11-15 11:35     ` Juergen Beisert
2010-11-17  8:36       ` Sascha Hauer
2010-10-26 11:31 ` [PATCH 09/12] STM378x: Add video driver for this platform Juergen Beisert
2010-10-26 11:31 ` [PATCH 10/12] Remove variable size restrictions Juergen Beisert
2010-10-26 11:31 ` [PATCH 11/12] Add doxygen documentation to the framebfuffer code Juergen Beisert
2010-10-26 11:31 ` [PATCH 12/12] Provide more driver specific data in a videomode Juergen Beisert
2010-11-01 13:19 ` [PATCHv2] Add dynamic video initialization to barebox Sascha Hauer
2010-11-01 13:29   ` Eric Bénard
2010-11-01 14:18     ` Sascha Hauer
2010-11-15  9:57   ` Juergen Beisert
2010-11-15 10:25     ` Belisko Marek
2010-11-17  8:44       ` Sascha Hauer
2010-11-18  8:18         ` Belisko Marek [this message]
2010-11-18 10:09           ` Sascha Hauer
2010-11-17  8:43     ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AANLkTimhJsC+aZYZsjVMkgTNDyQuAG1q+3LJaJVnJusV@mail.gmail.com \
    --to=marek.belisko@gmail.com \
    --cc=barebox@lists.infradead.org \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox