[PATCH] fixup! command: add hmac sum supportfor md5, sha1, sha224, sha256, sha384, sha512

[PATCH] fixup! command: add hmac sum supportfor md5, sha1, sha224, sha256, sha384, sha512

[Antony Pavlov]

---
 commands/hashsum.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/commands/hashsum.c b/commands/hashsum.c
index e2dc70e..8d3694f 100644
--- a/commands/hashsum.c
+++ b/commands/hashsum.c
@@ -36,7 +36,7 @@ static int do_hash(char *algo, int argc, char *argv[])
 	size_t keylen = 0;
 	int opt, ret;
 
-	while((opt = getopt(argc, argv, "h:")) > 0) {
+	while ((opt = getopt(argc, argv, "h:")) > 0) {
 		switch(opt) {
 		case 'h':
 			key = optarg;
-- 
2.1.4


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH] fixup! command: add hmac sum supportfor md5, sha1, sha224, sha256, sha384, sha512

[Jean-Christophe PLAGNIOL-VILLARD]

please write a better commit

it’s a coding style issue not a fixup
and here more a typo

Fixup means a BUG

Best Regards,
J.
> On Mar 28, 2015, at 12:23 AM, Antony Pavlov <antonynpavlov@gmail.com> wrote:
> 
> ---
> commands/hashsum.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/commands/hashsum.c b/commands/hashsum.c
> index e2dc70e..8d3694f 100644
> --- a/commands/hashsum.c
> +++ b/commands/hashsum.c
> @@ -36,7 +36,7 @@ static int do_hash(char *algo, int argc, char *argv[])
> 	size_t keylen = 0;
> 	int opt, ret;
> 
> -	while((opt = getopt(argc, argv, "h:")) > 0) {
> +	while ((opt = getopt(argc, argv, "h:")) > 0) {
> 		switch(opt) {
> 		case 'h':
> 			key = optarg;
> -- 
> 2.1.4
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH] fixup! command: add hmac sum supportfor md5, sha1, sha224, sha256, sha384, sha512

[Antony Pavlov]

On Sun, 29 Mar 2015 04:07:23 +0800
Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com> wrote:

> please write a better commit

The commit is made with 'git commit --fixup', so commit message is autogenerated.
The patch is send with autosquashing in mind.

Please read  http://fle.github.io/git-tip-keep-your-branch-clean-with-fixup-and-autosquash.html
for details.

> 
> it’s a coding style issue not a fixup
> and here more a typo
> 
> Fixup means a BUG
> 
> Best Regards,
> J.
> > On Mar 28, 2015, at 12:23 AM, Antony Pavlov <antonynpavlov@gmail.com> wrote:
> > 
> > ---
> > commands/hashsum.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/commands/hashsum.c b/commands/hashsum.c
> > index e2dc70e..8d3694f 100644
> > --- a/commands/hashsum.c
> > +++ b/commands/hashsum.c
> > @@ -36,7 +36,7 @@ static int do_hash(char *algo, int argc, char *argv[])
> > 	size_t keylen = 0;
> > 	int opt, ret;
> > 
> > -	while((opt = getopt(argc, argv, "h:")) > 0) {
> > +	while ((opt = getopt(argc, argv, "h:")) > 0) {
> > 		switch(opt) {
> > 		case 'h':
> > 			key = optarg;
> > -- 
> > 2.1.4
> > 
> > 
> > _______________________________________________
> > barebox mailing list
> > barebox@lists.infradead.org
> > http://lists.infradead.org/mailman/listinfo/barebox
> 


-- 
-- 
Best regards,
  Antony Pavlov

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH] fixup! command: add hmac sum supportfor md5, sha1, sha224, sha256, sha384, sha512

[Holger Schurig]

Antony,

that git has such a function doesn't mean that it is usable in any git
project. I too, like Jean-Christophe, that a style issue shouldn't be
named as a fix,

You could always do "git commit --amend" to change the message so that
it actually describes what happens.

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH] fixup! command: add hmac sum supportfor md5, sha1, sha224, sha256, sha384, sha512

[Antony Pavlov]

On Thu, 2 Apr 2015 09:11:33 +0200
Holger Schurig <holgerschurig@gmail.com> wrote:

> Antony,
> 
> that git has such a function doesn't mean that it is usable in any git
> project. I too, like Jean-Christophe, that a style issue shouldn't be
> named as a fix,
> 
> You could always do "git commit --amend" to change the message so that
> it actually describes what happens.

AFAIR Sascha (it's him who applies patches to next) has no problems with "fixup !" patches.

-- 
Best regards,
  Antony Pavlov

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH] fixup! command: add hmac sum supportfor md5, sha1, sha224, sha256, sha384, sha512

[Sascha Hauer]

On Thu, Apr 02, 2015 at 09:11:33AM +0200, Holger Schurig wrote:
> Antony,
> 
> that git has such a function doesn't mean that it is usable in any git
> project. I too, like Jean-Christophe, that a style issue shouldn't be
> named as a fix,

The patch Antony sent has been generated with git commit --fixup. I'll
apply it to the appropriate branch and run a git rebase --autosquash
over it. This makes it very easy for Antony to generate this patch and
easy for me to find and fixup the correct patch. We could also use
--squash instead of --fixup. That would keep both commit messages,
but that might be desirable.

Sascha


-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox