From: Antony Pavlov <antonynpavlov@gmail.com>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 2/2] Add MIPS arch support to barebox
Date: Tue, 28 Jun 2011 13:03:36 +0400 [thread overview]
Message-ID: <BANLkTi=MjbrK7EKMv7=u7S+M2bju4umBZA@mail.gmail.com> (raw)
In-Reply-To: <20110628072147.GG6069@pengutronix.de>
On 28/06/2011, Sascha Hauer <s.hauer@pengutronix.de> wrote:
> On Mon, Jun 27, 2011 at 09:13:54PM +0400, Antony Pavlov wrote:
>> Only supported board is qemu malta:
>> * barebox works in uncached memory;
>> * no peripherals support, but serial port.
>>
>> Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com>
>
> Looks mostly good, some comments inline.
...
>>
>> diff --git a/arch/mips/boards/malta/serial.c
>> b/arch/mips/boards/malta/serial.c
>> new file mode 100644
>> index 0000000..b3ade0c
>> --- /dev/null
>> +++ b/arch/mips/boards/malta/serial.c
...
>
> The whole file is inside CONFIG_DRIVER_SERIAL_NS16550, so you can do
> a obj-$(CONFIG_DRIVER_SERIAL_NS16550) += serial.o in the Makefile
> instead.
Ok.
>> diff --git a/arch/mips/configs/malta_defconfig
>> b/arch/mips/configs/malta_defconfig
>
> Please generate your defconfig file with make savedefconfig
I have know nothing about savedefconfig. I will use it.
>> +/**
>> + * @file
>> + * @brief mips posix types
>> + *
>> + * Minimal set to make all the other header files copied from the Linxu
>> kernel happy
>
> s/Linxu/Linux/
>
I did't used spell checker, but I must do.
:)
...
>> +void reset_cpu(ulong addr)
>> +{
>> + /** How to reset the machine? */
>
> I don't know either. We should add some printf here until we know.
>
qemu malta board has magic register to reset the machine
(see "SOFTRES Register" in qemu.git/hw/mips_malta.c).
For other board we can easily jump to start of bootrom. I think it is
possible in th future to introduce option to configure reset_cpu()'s
behavior.
--
Best regards,
Antony Pavlov
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2011-06-28 9:10 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-27 17:13 [PATCH 1/2] include/linux/stat.h: make struct stat unified Antony Pavlov
2011-06-27 17:13 ` [PATCH 2/2] Add MIPS arch support to barebox Antony Pavlov
2011-06-28 5:11 ` Jean-Christophe PLAGNIOL-VILLARD
2011-06-28 6:14 ` Antony Pavlov
2011-06-28 9:37 ` Antony Pavlov
2011-06-28 10:06 ` Sascha Hauer
2011-06-28 13:29 ` Jean-Christophe PLAGNIOL-VILLARD
2011-06-28 16:23 ` Shinya Kuribayashi
2011-06-28 7:21 ` Sascha Hauer
2011-06-28 9:03 ` Antony Pavlov [this message]
2011-06-28 15:06 ` Shinya Kuribayashi
2011-06-28 15:42 ` Antony Pavlov
2011-06-28 6:40 ` [PATCH 1/2] include/linux/stat.h: make struct stat unified Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='BANLkTi=MjbrK7EKMv7=u7S+M2bju4umBZA@mail.gmail.com' \
--to=antonynpavlov@gmail.com \
--cc=barebox@lists.infradead.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox