Re: [PATCH 2/2] Add MIPS arch support to barebox

[Antony Pavlov <antonynpavlov@gmail.com>]

On 28 June 2011 19:06, Shinya Kuribayashi <skuribay@pobox.com> wrote:
> On 6/28/11 2:13 AM, Antony Pavlov wrote:
>>
>> diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig
>> new file mode 100644
>> index 0000000..10c0fbb
>> --- /dev/null
>> +++ b/arch/mips/Kconfig
>> @@ -0,0 +1,55 @@
>
> [...]
>>
>> +source arch/mips/mach-qemu/Kconfig
>> +
>> +choice
>> +       prompt "Bring up type"
>> +
>> +       config MIPS_NATIVE_BRINGUP
>> +               bool "native"
>> +               help
>> +                  Barebox will act as a native bootloader. This includes
>> all the
>> +                  required initialization needed to bring up a piece of
>> hardware.
>> +
>> +endchoice
>
> Native bringup / native bootloader should be replaced with
> something more appropriate or descriptive.

I think that there is no need of this option in initial mips support.

In my everyday practice with the barebox-like firmware I use two
different type of firmware:
  * firmware, burned to the ROM (native bringup), this is principal
modus vivendi for firmware;
  * RAM-loadable firmware. This type of firmware is usable in case of
board damage or critical error of ROM firmware. Also RAM-loadable
firmware usable for testing of new version of firmware.

I think it is desirable to add this parameter in the future.

>> diff --git a/arch/mips/boot/entry.c b/arch/mips/boot/entry.c
>> new file mode 100644
>> index 0000000..98d954e
>> --- /dev/null
>> +++ b/arch/mips/boot/entry.c
>> @@ -0,0 +1,80 @@
>> +/*
>> + * (C) Copyright 2000-2006
>> + * Wolfgang Denk, DENX Software Engineering, wd@denx.de.
>
> Which part in this file belongs to Wolfgang?  I don't see any, and
> recommend you to replace with yours.
>

Hmm. You are right.

-- 
Best regards,
  Antony Pavlov

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox