Re: pull request complete support

[Hubert Feurstein <h.feurstein@gmail.com>]

Hi Jean-Christophe,

I've tested it in the sandbox and get an access violation when I type
"dev<TAB>". Here is the backtrace:

#0  0x0040dd1b in strlen (s=0x0) at lib/string.c:228
#1  0x00404652 in device_param_complete (begin=0 '\000',
dev=0xb763fa94, sl=0xbfffefe0, instr=0x0) at common/complete.c:115
#2  0x00404a24 in env_param_complete (sl=0xbfffefe0, instr=0x426160
"dev", eval=0) at common/complete.c:209
#3  0x00404c59 in complete (instr=0x426160 "dev", outstr=0xbffff064)
at common/complete.c:282
#4  0x00415687 in readline (prompt=0x426ac0 "barebox:/ ", buf=0x426160
"dev", len=1024) at lib/readline.c:209
#5  0x00401363 in get_user_input (i=0xbffff1c8) at common/hush.c:414
#6  0x004014c2 in file_get (i=0xbffff1c8) at common/hush.c:463
#7  0x00402e4f in parse_stream (dest=0xbffff154, ctx=0xbffff198,
input=0xbffff1c8, end_trigger=10) at common/hush.c:1278
#8  0x00402fd2 in parse_stream_outer (ctx=0xbffff198, inp=0xbffff1c8,
flag=2) at common/hush.c:1428
#9  0x00403770 in run_shell () at common/hush.c:1647
#10 0x00407d6a in start_barebox () at common/startup.c:167
#11 0x0041f082 in main ()

Best Regards
Hubert

2011/6/9 Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>:
> Hi,
>
>        This patch series add the support of the complete for :
>        - var and device param (set and get)
>        - generic command complete framework
>        - devinfo
>        - help
>        - empty command complete
>        - eth interface
>
>        this will also include the move driver and bus code to drivers/base
>        patch as this series depend on it
>
>        Please pull
> The following changes since commit 6e27bfb15e4e2446753fe9affcc3128772205cec:
>
>  Merge branch 'next' (2011-06-06 11:29:45 +0200)
>
> are available in the git repository at:
>
>  git://uboot.jcrosoft.org/barebox.git complete
>
> Jean-Christophe PLAGNIOL-VILLARD (7):
>      move driver and bus code to drivers/base
>      complete: add var and device param complete support
>      complete: add generic command complete framework
>      complete: add device name complete support for devinfo
>      complete: add help complete support
>      complete: add empty complete support
>      complete: add eth interface complete support
>
>  arch/arm/cpu/cpuinfo.c                   |    2 +
>  arch/arm/mach-imx/speed.c                |    2 +
>  arch/arm/mach-mxs/imx.c                  |    2 +
>  commands/clear.c                         |    2 +
>  commands/false.c                         |    2 +
>  commands/help.c                          |    2 +
>  commands/login.c                         |    2 +
>  commands/lsmod.c                         |    2 +
>  commands/meminfo.c                       |    2 +
>  commands/net.c                           |    2 +
>  commands/passwd.c                        |    2 +
>  commands/pwd.c                           |    2 +
>  commands/reginfo.c                       |    2 +
>  commands/reset.c                         |    2 +
>  commands/true.c                          |    2 +
>  commands/usb.c                           |    2 +
>  commands/version.c                       |    2 +
>  common/complete.c                        |  183 ++++++++++++++++++++++++++++--
>  drivers/Makefile                         |    1 +
>  drivers/base/Makefile                    |    2 +
>  {lib => drivers/base}/driver.c           |    2 +
>  lib/bus.c => drivers/base/platform_bus.c |    0
>  drivers/usb/gadget/u_serial.c            |    2 +
>  include/command.h                        |    8 ++
>  include/complete.h                       |    7 +
>  lib/Makefile                             |    2 -
>  net/dhcp.c                               |    2 +
>  net/eth.c                                |   23 ++++
>  28 files changed, 253 insertions(+), 13 deletions(-)
>  create mode 100644 drivers/base/Makefile
>  rename {lib => drivers/base}/driver.c (99%)
>  rename lib/bus.c => drivers/base/platform_bus.c (100%)
>
> Best Regards,
> J.
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
>

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox