From: "Renaud C." <r.cerrato@til-technologies.fr>
To: barebox <barebox@lists.infradead.org>
Subject: [PATCH 5/7] gadget: possible null pointer dereference fix
Date: Tue, 12 Mar 2013 17:05:11 +0100 [thread overview]
Message-ID: <CA+7xNQmARo+pXakUUW=8YqBKF2mq9j-00ybSzQ4r9wCe4rPSyA@mail.gmail.com> (raw)
[-- Attachment #1.1: Type: text/plain, Size: 109 bytes --]
This patch fix a possible null pointer dereference exception because of a
missing null check on cdev->config
[-- Attachment #1.2: Type: text/html, Size: 163 bytes --]
[-- Attachment #2: gadget-null-pointer-dereference-fix.patch --]
[-- Type: application/octet-stream, Size: 1215 bytes --]
From 37b7dc7f2232b54f8fc8a5590245af37fe7d8299 Mon Sep 17 00:00:00 2001
From: Cerrato Renaud <r.cerrato@til-technologies.fr>
Date: Thu, 28 Feb 2013 15:04:53 +0100
Subject: [PATCH 3/3] null pointer dereference fix
---
drivers/usb/gadget/composite.c | 23 +++++++++++++----------
1 files changed, 13 insertions(+), 10 deletions(-)
diff --git a/drivers/usb/gadget/composite.c b/drivers/usb/gadget/composite.c
index 9af115e..1f6c5b2 100644
--- a/drivers/usb/gadget/composite.c
+++ b/drivers/usb/gadget/composite.c
@@ -777,18 +777,21 @@ unknown:
* recipients (endpoint, other, WUSB, ...) to the current
* configuration code.
*/
- f = cdev->config->interface[intf];
- if (f && f->setup)
- value = f->setup(f, ctrl);
- else
- f = NULL;
+ if(cdev->config) {
- if (value < 0 && !f) {
- struct usb_configuration *c;
+ f = cdev->config->interface[intf];
+ if (f && f->setup)
+ value = f->setup(f, ctrl);
+ else
+ f = NULL;
- c = cdev->config;
- if (c && c->setup)
- value = c->setup(c, ctrl);
+ if (value < 0 && !f) {
+ struct usb_configuration *c;
+
+ c = cdev->config;
+ if (c && c->setup)
+ value = c->setup(c, ctrl);
+ }
}
goto done;
--
1.7.2.5
[-- Attachment #3: Type: text/plain, Size: 149 bytes --]
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next reply other threads:[~2013-03-12 16:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-12 16:05 Renaud C. [this message]
2013-03-13 10:32 ` Cerrato Renaud
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+7xNQmARo+pXakUUW=8YqBKF2mq9j-00ybSzQ4r9wCe4rPSyA@mail.gmail.com' \
--to=r.cerrato@til-technologies.fr \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox