From: Antony Pavlov <antonynpavlov@gmail.com>
To: barebox <barebox@lists.infradead.org>
Subject: Re: [RFC 2/3] MIPS: add the initial support for lowlevel init
Date: Mon, 14 May 2012 13:13:49 +0400 [thread overview]
Message-ID: <CAA4bVAFAo+Sn1gB1bb=hjFC3gx26E8UmiGKPfnKa6Qu+RfBugQ@mail.gmail.com> (raw)
In-Reply-To: <20120514085532.GJ13302@pengutronix.de>
On 14 May 2012 12:55, Sascha Hauer <s.hauer@pengutronix.de> wrote:
> On Sun, May 13, 2012 at 09:24:43PM +0400, Antony Pavlov wrote:
>> This commit introduce the initial support for
>> machine specific lowlevel initialization
>> (e.g. RAM controller or cache memory).
>>
>> To return from mach_init_lowlevel() it uses
>> explicit mach_init_lowlevel_return label.
>> This saves ra register for using inside mach_init_lowlevel()
>>
>> Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com>
>> ---
>> arch/mips/boot/start.S | 8 ++++++++
>> 1 file changed, 8 insertions(+)
>>
>> diff --git a/arch/mips/boot/start.S b/arch/mips/boot/start.S
>> index 6bf5baa..6db104b 100644
>> --- a/arch/mips/boot/start.S
>> +++ b/arch/mips/boot/start.S
>> @@ -74,6 +74,14 @@ __start:
>> and k0, k1
>> mtc0 k0, CP0_STATUS
>>
>> +#ifdef CONFIG_MACH_DO_LOWLEVEL_INIT
>> + b mach_init_lowlevel
>> + nop
> ^^^^
>
> Space after tab.
It not a bug, it is a feature! :))
The nop instruction is in a branch delay slot, so add a space before it.
--
Best regards,
Antony Pavlov
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2012-05-14 9:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-13 17:24 [RFC 0/3] " Antony Pavlov
2012-05-13 17:24 ` [RFC 1/3] MIPS: move start.S code to .text_entry section Antony Pavlov
2012-05-13 17:24 ` [RFC 2/3] MIPS: add the initial support for lowlevel init Antony Pavlov
2012-05-14 8:55 ` Sascha Hauer
2012-05-14 9:13 ` Antony Pavlov [this message]
2012-05-13 17:24 ` [RFC 3/3] MIPS: malta: add bogus " Antony Pavlov
2012-05-14 8:18 ` [RFC 0/3] MIPS: add the initial support for " Sascha Hauer
2012-05-14 8:28 ` Antony Pavlov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAA4bVAFAo+Sn1gB1bb=hjFC3gx26E8UmiGKPfnKa6Qu+RfBugQ@mail.gmail.com' \
--to=antonynpavlov@gmail.com \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox