From: Antony Pavlov <antonynpavlov@gmail.com>
To: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 1/1] complete: fix duplicate env eval list
Date: Thu, 3 May 2012 22:00:30 +0400 [thread overview]
Message-ID: <CAA4bVAFLC7iHa7+S4-6qx9bZCQzPMMUqBu4OSkK7_4iYrSZAQg@mail.gmail.com> (raw)
In-Reply-To: <1336032068-19869-1-git-send-email-plagnioj@jcrosoft.com>
I have just checked this patch.
The patch fixes the problem with dubbing.
On 3 May 2012 12:01, Jean-Christophe PLAGNIOL-VILLARD
<plagnioj@jcrosoft.com> wrote:
> this can be reproductable by this sequence
>
> barebox:/ <TAB>
> . ? [ addpart
> bootm cat cd clear
> cp cpuinfo crc32 delpart
> devinfo dhcp echo edit
> erase ethact exit export
> false getopt go help
> host loadb loadenv loady
> login ls md md5sum
> memcmp memcpy meminfo memset
> menu mkdir mount mtest
> mw nfs passwd ping
> printenv protect pwd readline
> reset rm rmdir saveenv
> sedit sh sha1sum sha256sum
> sleep source test tftp
> time timeout true umount
> uncompress unprotect version net.nameserver=
> net.domainname= cs0.baudrate= cs0.active= cs1.active=
> cs1.ip= cs1.port=
> barebox:/ $<TAB>
> $net.nameserver $net.domainname $cs0.baudrate
> $cs0.active $cs1.active $cs1.ip
> $cs1.port $net.nameserver $net.domainname
> $cs0.baudrate $cs0.active $cs1.active
> $cs1.ip $cs1.port
> barebox:/ $
>
> Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
> ---
> common/complete.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/common/complete.c b/common/complete.c
> index 0b03d7c..0780888 100644
> --- a/common/complete.c
> +++ b/common/complete.c
> @@ -272,7 +272,7 @@ static char* cmd_complete_lookup(struct string_list *sl, char *instr)
> {
> struct command *cmdtp;
> int len;
> - int ret = 1;
> + int ret = COMPLETE_END;
> char *res = NULL;
>
> for_each_command(cmdtp) {
> --
> 1.7.9.1
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
--
Best regards,
Antony Pavlov
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2012-05-03 18:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-03 8:01 Jean-Christophe PLAGNIOL-VILLARD
2012-05-03 18:00 ` Antony Pavlov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAA4bVAFLC7iHa7+S4-6qx9bZCQzPMMUqBu4OSkK7_4iYrSZAQg@mail.gmail.com \
--to=antonynpavlov@gmail.com \
--cc=barebox@lists.infradead.org \
--cc=plagnioj@jcrosoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox