From: Antony Pavlov <antonynpavlov@gmail.com>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] usb: ehci: initialize ehci_data
Date: Fri, 8 Mar 2013 09:57:10 +0400 [thread overview]
Message-ID: <CAA4bVAFTT=34QtjaJdvs5Fg6bBKmMN-W4XYYiTbtT1vbCj+HJw@mail.gmail.com> (raw)
In-Reply-To: <1362412809-23253-1-git-send-email-s.hauer@pengutronix.de>
On 4 March 2013 20:00, Sascha Hauer <s.hauer@pengutronix.de> wrote:
> Without it fields of ehci_data may be unitialized and the driver
> crashes.
Sascha!
Please apply a patch like this! Without it the 'usb' command on my
Tegra board hangs.
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> ---
> drivers/usb/host/ehci-hcd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/host/ehci-hcd.c b/drivers/usb/host/ehci-hcd.c
> index 0c789e4..7c389aa 100644
> --- a/drivers/usb/host/ehci-hcd.c
> +++ b/drivers/usb/host/ehci-hcd.c
> @@ -892,7 +892,7 @@ int ehci_register(struct device_d *dev, struct ehci_data *data)
>
> static int ehci_probe(struct device_d *dev)
> {
> - struct ehci_data data;
> + struct ehci_data data = {};
> struct ehci_platform_data *pdata = dev->platform_data;
>
> /* default to EHCI_HAS_TT to not change behaviour of boards
> --
> 1.7.10.4
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
--
Best regards,
Antony Pavlov
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2013-03-08 5:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-04 16:00 Sascha Hauer
2013-03-04 19:05 ` Jean-Christophe PLAGNIOL-VILLARD
2013-03-04 19:16 ` Sascha Hauer
2013-03-04 19:25 ` Alexander Aring
2013-03-04 19:28 ` Sascha Hauer
2013-03-04 19:32 ` Alexander Aring
2013-03-08 5:57 ` Antony Pavlov [this message]
2013-03-08 7:24 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAA4bVAFTT=34QtjaJdvs5Fg6bBKmMN-W4XYYiTbtT1vbCj+HJw@mail.gmail.com' \
--to=antonynpavlov@gmail.com \
--cc=barebox@lists.infradead.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox