mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Antony Pavlov <antonynpavlov@gmail.com>
To: barebox <barebox@lists.infradead.org>
Subject: [RFC] arm naming inconsistance
Date: Fri, 12 Aug 2011 17:28:17 +0400	[thread overview]
Message-ID: <CAA4bVAFYh0z-DCYbB8WoZZkBHszDHjmrYAF2D89drCSvSdCKZQ@mail.gmail.com> (raw)

Hi!

Barebox has an hierarchy for supported stuff:

 arch -> mach

    arch \in {arm, x86, nios2 ...}

 for arch=arm, mach \in { at91, ims, msx, ... versatile }

 Also there is the 'board', the lowest level of hierarchy.

 E.g. for mach=at91, board \in { at91sam9m10g45ek, pm9263 ...}

But there are strange things in arch/arm/Kconfig and
arch/arm/cpu/start.c:

#ifdef CONFIG_ARCH_HAS_LOWLEVEL_INIT
        arch_init_lowlevel();
#endif

At the first glance all ok: if arch has lowlevel init, the do
arch_init_lowlevel().
But arch_init_lowlevel() is not __per-arch__ function, but
__per-mach__ function!
It is used in at91 and omap mach.

#ifdef CONFIG_MACH_DO_LOWLEVEL_INIT
        board_init_lowlevel();
#endif

Here we have a more bizarre thing: if __mach__ do low level init then
do __board__ low level init!

In arch/arm/Kconfig we have the same strange things:

config ARCH_VERSATILE
        bool "ARM Versatile boards (ARM926EJ-S)"
        select CPU_ARM926T

But versatile is not arch, it's a mach!

By this examples one can see that the conception of architecture
('arch') is mixed up with the conception of machine ('mach').

Can anybody explain this?

-- 
Best regards,
  Antony Pavlov

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

             reply	other threads:[~2011-08-12 13:28 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-12 13:28 Antony Pavlov [this message]
2011-08-12 13:38 ` Jean-Christophe PLAGNIOL-VILLARD
2011-08-25 10:30 ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAA4bVAFYh0z-DCYbB8WoZZkBHszDHjmrYAF2D89drCSvSdCKZQ@mail.gmail.com \
    --to=antonynpavlov@gmail.com \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox