From: Antony Pavlov <antonynpavlov@gmail.com>
To: barebox <barebox@lists.infradead.org>
Subject: serial_ns16550 driver question
Date: Wed, 20 Jul 2011 23:51:04 +0400 [thread overview]
Message-ID: <CAA4bVAGTD7BQxa-wh=i8iiZX33aQOR3g1O5o7_G6XQkYCgShnw@mail.gmail.com> (raw)
Hi!
In include/ns16550.h we have:
struct NS16550_plat {
unsigned int clock;
unsigned char f_caps;
/**
* register read access capability
*/
unsigned int (*reg_read) (unsigned long base, unsigned char reg_offset);
/**
* register write access capability
*/
void (*reg_write) (unsigned int val, unsigned long base,
unsigned char reg_offset);
};
Why reg_read and reg_write's argument base has type unsigned long?
IMHO pointer type (void * or char *) is more natural.
--
Best regards,
Antony Pavlov
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next reply other threads:[~2011-07-20 19:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-20 19:51 Antony Pavlov [this message]
2011-07-20 20:31 ` Sascha Hauer
2011-07-21 3:12 ` Jean-Christophe PLAGNIOL-VILLARD
2011-07-21 6:28 ` Sascha Hauer
2011-07-21 8:34 ` Juergen Beisert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAA4bVAGTD7BQxa-wh=i8iiZX33aQOR3g1O5o7_G6XQkYCgShnw@mail.gmail.com' \
--to=antonynpavlov@gmail.com \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox