From: Antony Pavlov <antonynpavlov@gmail.com>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [RFC] MIPS: XBurst: suitable solution for per-board debug_ll options
Date: Thu, 31 May 2012 23:09:18 +0400 [thread overview]
Message-ID: <CAA4bVAGgtSCt=hGO5cFisKYQoG6Mj620UFwcHFmBQtqcxZvQVQ@mail.gmail.com> (raw)
In-Reply-To: <20120531185203.GD30400@pengutronix.de>
On 31 May 2012 22:52, Sascha Hauer <s.hauer@pengutronix.de> wrote:
> On Thu, May 24, 2012 at 05:50:20PM +0400, Antony Pavlov wrote:
>> In the commit 40492a0c1305835c996e15eb1cce2406473ae76d
>> (MIPS: add common header file for DEBUG_LL via NS16550)
>> introduced common DEBUG_LL via NS16550 for MIPS
>> (see file arch/mips/include/debug_ll_ns16550.h).
>>
>> In the commit 1cbe2b2c00de0efca503a983d0d008833f186f33
>> (MIPS: XBurst: add Ritmix RZX-50 board support)
>> the file debug_ll_ns16550.h used in
>> the file arch/mips/mach-xburst/include/mach/debug_ll.h.
>>
>> Usage looks like this:
>>
>> ------------------------------------------------
>> +#ifdef CONFIG_BOARD_RZX50
>> +#include <mach/debug_ll_jz4755.h>
>> +#endif
>> +
>> +#include <debug_ll_ns16550.h>
>> ------------------------------------------------
>>
>> So after adding another board (e.g. A320) we will have something like this:
>>
>> ------------------------------------------------
>> #ifdef CONFIG_BOARD_RZX50
>> #include <mach/debug_ll_jz4755.h>
>> #endif
>>
>> +#ifdef CONFIG_BOARD_A320
>> +#include <mach/debug_ll_jz4740.h>
>> +#endif
>>
>> #include <debug_ll_ns16550.h>
>> ------------------------------------------------
>>
>> This approach has disadvantage:
>> * the files mach/debug_ll_jz4740.h and mach/debug_ll_jz4755.h
>> (they go to arch/mips/arch-xburst) are __BOARD-SPECIFIC__
>> (not SOC- or mach-specific!); The file mach-xburst/include/mach/debug_ll.h
>> is outside board directory, but it contain some board related information.
>>
>> This commit introduce more suitable solution.
>
> Looks good. OK to apply?
No, please. There is a trivial mistype in this patch.
I'll resend the fixed patch in a short time.
--
Best regards,
Antony Pavlov
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2012-05-31 19:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-24 13:50 Antony Pavlov
2012-05-31 18:52 ` Sascha Hauer
2012-05-31 19:09 ` Antony Pavlov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAA4bVAGgtSCt=hGO5cFisKYQoG6Mj620UFwcHFmBQtqcxZvQVQ@mail.gmail.com' \
--to=antonynpavlov@gmail.com \
--cc=barebox@lists.infradead.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox