From: Antony Pavlov <antonynpavlov@gmail.com>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [RFC-PATCH] Fix loads command
Date: Mon, 22 Aug 2011 22:36:24 +0400 [thread overview]
Message-ID: <CAA4bVAHLeVzJsi1CQE3w-QV91d-m9DdD88m9K=jXGq7GvhAO=w@mail.gmail.com> (raw)
In-Reply-To: <20110822065844.GW31404@pengutronix.de>
On 22 August 2011 10:58, Sascha Hauer <s.hauer@pengutronix.de> wrote:
> Hi Antony,
>
> On Sun, Aug 21, 2011 at 11:08:40PM +0400, Antony Pavlov wrote:
>> Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com>
>> ---
>> commands/Kconfig | 7 +-
>> commands/Makefile | 1 -
>> commands/loads.c | 295 ++++++++++++++++++++++++++++++-----------------------
>> common/Makefile | 1 +
>> 4 files changed, 171 insertions(+), 133 deletions(-)
>
> There seem to be many whitespace cleanups in this patch. Can you please
> post a seperate patch for these for easier review?
...
> A good start would be to cleanup the coding style and to make it compile
> again.
I shall send the new patch series in a few minutes.
This patch series will make loads compile again and fix coding style /
compiler's warning.
For simplicity baudrate switching code was removed.
We can add it in the future. Also it isn't very difficult to switch
from direct memory writing to file descriptor writing.
--
Best regards,
Antony Pavlov
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2011-08-22 18:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-21 19:08 Antony Pavlov
2011-08-22 6:58 ` Sascha Hauer
2011-08-22 18:36 ` Antony Pavlov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAA4bVAHLeVzJsi1CQE3w-QV91d-m9DdD88m9K=jXGq7GvhAO=w@mail.gmail.com' \
--to=antonynpavlov@gmail.com \
--cc=barebox@lists.infradead.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox