From: vj <vicencb@gmail.com>
To: J.Weitzel@phytec.de
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] OMAP4: Use default clock source for mcbsp
Date: Wed, 5 Jun 2013 22:50:32 +0200 [thread overview]
Message-ID: <CAAMcf8AczuT9Z+6Tn3YzrrBe4KXziiR+D+2tb6RvUxZYb=eugA@mail.gmail.com> (raw)
In-Reply-To: <1370429778.3824.7.camel@lws-weitzel>
On Wed, Jun 5, 2013 at 12:56 PM, Jan Weitzel <J.Weitzel@phytec.de> wrote:
> Am Dienstag, den 04.06.2013, 16:53 +0200 schrieb Sascha Hauer:
>> Hi Jan,
>>
>> On Tue, May 28, 2013 at 01:51:40PM +0200, Jan Weitzel wrote:
>> > In omap4_enable_all_clocks we not only enable the mcbsp clocks, but also
>> > change the source from ABE_24M_FCLK to 24M_FCLK. Revert this and default
>> > to the reset state.
>>
>> Can you add a description why this is necessary?
> We had some trouble because the kernel takes the default clock sources
> from the registers. There seams to be no reason to change them in the
> boot loader. Is clean up a good enough answer?
> Could someone test it on pandaboard and ArchosG9? I didn't have
> (working) hardware here.
>
I've seen no regressions on ArchosG9.
Regards,
Vicente.
> Jan
>>
>> Sascha
>>
>> >
>> > Signed-off-by: Jan Weitzel <j.weitzel@phytec.de>
>> > ---
>> > arch/arm/mach-omap/omap4_clock.c | 6 +++---
>> > 1 files changed, 3 insertions(+), 3 deletions(-)
>> >
>> > diff --git a/arch/arm/mach-omap/omap4_clock.c b/arch/arm/mach-omap/omap4_clock.c
>> > index 0621fd3..889d1f9 100644
>> > --- a/arch/arm/mach-omap/omap4_clock.c
>> > +++ b/arch/arm/mach-omap/omap4_clock.c
>> > @@ -253,9 +253,9 @@ void omap4_enable_all_clocks(void)
>> > sr32(CM1_ABE_PDM_CLKCTRL, 0, 32, 0x2);
>> > sr32(CM1_ABE_DMIC_CLKCTRL, 0, 32, 0x2);
>> > sr32(CM1_ABE_MCASP_CLKCTRL, 0, 32, 0x2);
>> > - sr32(CM1_ABE_MCBSP1_CLKCTRL, 0, 32, 0x08000002);
>> > - sr32(CM1_ABE_MCBSP2_CLKCTRL, 0, 32, 0x08000002);
>> > - sr32(CM1_ABE_MCBSP3_CLKCTRL, 0, 32, 0x08000002);
>> > + sr32(CM1_ABE_MCBSP1_CLKCTRL, 0, 32, 0x2);
>> > + sr32(CM1_ABE_MCBSP2_CLKCTRL, 0, 32, 0x2);
>> > + sr32(CM1_ABE_MCBSP3_CLKCTRL, 0, 32, 0x2);
>> > sr32(CM1_ABE_SLIMBUS_CLKCTRL, 0, 32, 0xf02);
>> > sr32(CM1_ABE_TIMER5_CLKCTRL, 0, 32, 0x2);
>> > sr32(CM1_ABE_TIMER6_CLKCTRL, 0, 32, 0x2);
>> > --
>> > 1.7.0.4
>> >
>> >
>> > _______________________________________________
>> > barebox mailing list
>> > barebox@lists.infradead.org
>> > http://lists.infradead.org/mailman/listinfo/barebox
>> >
>>
>
>
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2013-06-05 20:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-28 11:51 Jan Weitzel
2013-06-04 14:53 ` Sascha Hauer
2013-06-05 10:56 ` Jan Weitzel
2013-06-05 20:50 ` vj [this message]
2013-06-08 13:13 ` Sascha Hauer
2013-06-12 7:14 ` Jan Weitzel
2013-06-17 7:14 ` Sascha Hauer
2013-06-17 8:00 ` Jan Weitzel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAAMcf8AczuT9Z+6Tn3YzrrBe4KXziiR+D+2tb6RvUxZYb=eugA@mail.gmail.com' \
--to=vicencb@gmail.com \
--cc=J.Weitzel@phytec.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox