From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-pb0-x236.google.com ([2607:f8b0:400e:c01::236]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1UkKfZ-0006as-KV for barebox@lists.infradead.org; Wed, 05 Jun 2013 20:50:58 +0000 Received: by mail-pb0-f54.google.com with SMTP id ro2so2306383pbb.13 for ; Wed, 05 Jun 2013 13:50:35 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <1370429778.3824.7.camel@lws-weitzel> References: <1369741903-24988-2-git-send-email-j.weitzel@phytec.de> <20130604145327.GJ32299@pengutronix.de> <1370429778.3824.7.camel@lws-weitzel> Date: Wed, 5 Jun 2013 22:50:32 +0200 Message-ID: From: vj List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH] OMAP4: Use default clock source for mcbsp To: J.Weitzel@phytec.de Cc: barebox@lists.infradead.org On Wed, Jun 5, 2013 at 12:56 PM, Jan Weitzel wrote: > Am Dienstag, den 04.06.2013, 16:53 +0200 schrieb Sascha Hauer: >> Hi Jan, >> >> On Tue, May 28, 2013 at 01:51:40PM +0200, Jan Weitzel wrote: >> > In omap4_enable_all_clocks we not only enable the mcbsp clocks, but also >> > change the source from ABE_24M_FCLK to 24M_FCLK. Revert this and default >> > to the reset state. >> >> Can you add a description why this is necessary? > We had some trouble because the kernel takes the default clock sources > from the registers. There seams to be no reason to change them in the > boot loader. Is clean up a good enough answer? > Could someone test it on pandaboard and ArchosG9? I didn't have > (working) hardware here. > I've seen no regressions on ArchosG9. Regards, Vicente. > Jan >> >> Sascha >> >> > >> > Signed-off-by: Jan Weitzel >> > --- >> > arch/arm/mach-omap/omap4_clock.c | 6 +++--- >> > 1 files changed, 3 insertions(+), 3 deletions(-) >> > >> > diff --git a/arch/arm/mach-omap/omap4_clock.c b/arch/arm/mach-omap/omap4_clock.c >> > index 0621fd3..889d1f9 100644 >> > --- a/arch/arm/mach-omap/omap4_clock.c >> > +++ b/arch/arm/mach-omap/omap4_clock.c >> > @@ -253,9 +253,9 @@ void omap4_enable_all_clocks(void) >> > sr32(CM1_ABE_PDM_CLKCTRL, 0, 32, 0x2); >> > sr32(CM1_ABE_DMIC_CLKCTRL, 0, 32, 0x2); >> > sr32(CM1_ABE_MCASP_CLKCTRL, 0, 32, 0x2); >> > - sr32(CM1_ABE_MCBSP1_CLKCTRL, 0, 32, 0x08000002); >> > - sr32(CM1_ABE_MCBSP2_CLKCTRL, 0, 32, 0x08000002); >> > - sr32(CM1_ABE_MCBSP3_CLKCTRL, 0, 32, 0x08000002); >> > + sr32(CM1_ABE_MCBSP1_CLKCTRL, 0, 32, 0x2); >> > + sr32(CM1_ABE_MCBSP2_CLKCTRL, 0, 32, 0x2); >> > + sr32(CM1_ABE_MCBSP3_CLKCTRL, 0, 32, 0x2); >> > sr32(CM1_ABE_SLIMBUS_CLKCTRL, 0, 32, 0xf02); >> > sr32(CM1_ABE_TIMER5_CLKCTRL, 0, 32, 0x2); >> > sr32(CM1_ABE_TIMER6_CLKCTRL, 0, 32, 0x2); >> > -- >> > 1.7.0.4 >> > >> > >> > _______________________________________________ >> > barebox mailing list >> > barebox@lists.infradead.org >> > http://lists.infradead.org/mailman/listinfo/barebox >> > >> > > _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox