From: vj <vicencb@gmail.com>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 06/13] bootm: close open files
Date: Mon, 8 Oct 2012 23:02:04 +0200 [thread overview]
Message-ID: <CAAMcf8C-3-fuL2mDXMsTrezZhx9TwBAzZXWc+BPiV+noU67ndQ@mail.gmail.com> (raw)
In-Reply-To: <20121008201811.GR1322@pengutronix.de>
On Mon, Oct 8, 2012 at 10:18 PM, Sascha Hauer <s.hauer@pengutronix.de> wrote:
> On Mon, Oct 08, 2012 at 12:01:20AM +0200, Vicente wrote:
>>
>> Signed-off-by: Vicente <vicencb@gmail.com>
>> ---
>> arch/arm/lib/bootm.c | 4 +++-
>> commands/bootm.c | 6 +++++-
>> 2 files changed, 8 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/arm/lib/bootm.c b/arch/arm/lib/bootm.c
>> index c5b76ea..288c0b2 100644
>> --- a/arch/arm/lib/bootm.c
>> +++ b/arch/arm/lib/bootm.c
>> @@ -269,8 +269,9 @@ static int do_bootz_linux(struct image_data *data)
>>
>> ret = do_bootz_linux_fdt(fd, data);
>> if (ret && ret != -ENXIO)
>> - return ret;
>> + goto err_out;
>>
>> + close(fd);
>> return __do_bootm_linux(data, swap);
>
> ret = __do_bootm_linux and fall through?
>
> Sascha
>
>
> --
> Pengutronix e.K. | |
> Industrial Linux Solutions | http://www.pengutronix.de/ |
> Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
> Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
No,
__do_bootm_linux does not return if everything works ok.
From the barebox point of view there is no difference in closing or
not the files.
The difference is when the files are from a server.
Regards,
Vicente.
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2012-10-08 21:02 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-07 22:01 [PATCH 00/13] archosg9: add support for tablet, fourth round Vicente
2012-10-07 22:01 ` [PATCH 01/13] twl6030: add debug info Vicente
2012-10-07 22:01 ` [PATCH 02/13] omap4: add rename definitions to match datasheet Vicente
2012-10-07 22:01 ` [PATCH 03/13] ARM: ensure irqs are disabled Vicente
2012-10-08 20:21 ` Sascha Hauer
2012-10-07 22:01 ` [PATCH 04/13] omap: revert gpiolib Vicente
2012-10-07 22:01 ` [PATCH 05/13] omap4: add usb boot source Vicente
2012-10-07 22:01 ` [PATCH 06/13] bootm: close open files Vicente
2012-10-08 20:18 ` Sascha Hauer
2012-10-08 21:02 ` vj [this message]
2012-10-07 22:01 ` [PATCH 07/13] uimage: improve transfer speed Vicente
2012-10-08 20:01 ` Sascha Hauer
2012-10-08 20:48 ` vj
2012-10-07 22:01 ` [PATCH 08/13] fs: improve robustness Vicente
2012-10-07 22:01 ` [PATCH 09/13] omap4: add support for booting cpu from usb Vicente
2012-10-07 22:01 ` [PATCH 10/13] omap4: add serial communications over usb boot Vicente
2012-10-07 22:01 ` [PATCH 11/13] omap4: add filesystem support " Vicente
2012-10-07 22:01 ` [PATCH 12/13] omap4: add support for loading second stage from usb Vicente
2012-10-07 22:01 ` [PATCH 13/13] Add support for Archos G9 tablet Vicente
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAAMcf8C-3-fuL2mDXMsTrezZhx9TwBAzZXWc+BPiV+noU67ndQ@mail.gmail.com \
--to=vicencb@gmail.com \
--cc=barebox@lists.infradead.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox