scripts/checkpatch.pl is deprecated

scripts/checkpatch.pl is deprecated

[Vicente Bergas]

Hello,
when using scripts/checkpatch.pl it may report:
  Unescaped left brace in regex is deprecated,
  passed through in regex at scripts/checkpatch.pl line 2267.

This error is shown if a patch contains a left brace with
no preceding space like in:
  if(condition){

Should the script be fixed or updated?

Regards,
  Vicente.

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: scripts/checkpatch.pl is deprecated

[Uwe Kleine-König]

On Wed, Jan 11, 2017 at 08:35:11PM +0100, Vicente Bergas wrote:
> Hello,
> when using scripts/checkpatch.pl it may report:
>   Unescaped left brace in regex is deprecated,
>   passed through in regex at scripts/checkpatch.pl line 2267.

I bet this scripts originates from the kernel. So I'd recommend to test
if their version is affected to. If yes, report to them, if not, update
barebox to latest Linux version.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: scripts/checkpatch.pl is deprecated

[Ian Abbott]

On 11/01/17 20:07, Uwe Kleine-König wrote:
> On Wed, Jan 11, 2017 at 08:35:11PM +0100, Vicente Bergas wrote:
>> Hello,
>> when using scripts/checkpatch.pl it may report:
>>   Unescaped left brace in regex is deprecated,
>>   passed through in regex at scripts/checkpatch.pl line 2267.
>
> I bet this scripts originates from the kernel. So I'd recommend to test
> if their version is affected to. If yes, report to them, if not, update
> barebox to latest Linux version.

In the Linux kernel, this was fixed in commit 
6b8c69e4384b0bcf1936c2137804840212daaf69 ("checkpatch: fix another left 
brace warning"), which made it into the the 4.6 kernel.

-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@mev.co.uk> )=-
-=(                          Web: http://www.mev.co.uk/  )=-

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: scripts/checkpatch.pl is deprecated

[Vicente Bergas]

On Thu, Jan 12, 2017 at 11:27 AM, Ian Abbott <abbotti@mev.co.uk> wrote:
> On 11/01/17 20:07, Uwe Kleine-König wrote:
>>
>> On Wed, Jan 11, 2017 at 08:35:11PM +0100, Vicente Bergas wrote:
>>>
>>> Hello,
>>> when using scripts/checkpatch.pl it may report:
>>>   Unescaped left brace in regex is deprecated,
>>>   passed through in regex at scripts/checkpatch.pl line 2267.
>>
>>
>> I bet this scripts originates from the kernel. So I'd recommend to test
>> if their version is affected to. If yes, report to them, if not, update
>> barebox to latest Linux version.
>
>
> In the Linux kernel, this was fixed in commit
> 6b8c69e4384b0bcf1936c2137804840212daaf69 ("checkpatch: fix another left
> brace warning"), which made it into the the 4.6 kernel.
>
> --
> -=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@mev.co.uk> )=-
> -=(                          Web: http://www.mev.co.uk/  )=-

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: scripts/checkpatch.pl is deprecated

[Vicente Bergas]

On Thu, Jan 12, 2017 at 11:27 AM, Ian Abbott <abbotti@mev.co.uk> wrote:
> On 11/01/17 20:07, Uwe Kleine-König wrote:
>>
>> On Wed, Jan 11, 2017 at 08:35:11PM +0100, Vicente Bergas wrote:
>>>
>>> Hello,
>>> when using scripts/checkpatch.pl it may report:
>>>   Unescaped left brace in regex is deprecated,
>>>   passed through in regex at scripts/checkpatch.pl line 2267.
>>
>>
>> I bet this scripts originates from the kernel. So I'd recommend to test
>> if their version is affected to. If yes, report to them, if not, update
>> barebox to latest Linux version.
>
>
> In the Linux kernel, this was fixed in commit
> 6b8c69e4384b0bcf1936c2137804840212daaf69 ("checkpatch: fix another left
> brace warning"), which made it into the the 4.6 kernel.

This commit applies as is in barebox, so, can it be applied?
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/patch/?id=6b8c69e4384b0bcf1936c2137804840212daaf69

>
> --
> -=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@mev.co.uk> )=-
> -=(                          Web: http://www.mev.co.uk/  )=-

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: scripts/checkpatch.pl is deprecated

[Sascha Hauer]

On Sun, Jan 15, 2017 at 08:42:42PM +0100, Vicente Bergas wrote:
> On Thu, Jan 12, 2017 at 11:27 AM, Ian Abbott <abbotti@mev.co.uk> wrote:
> > On 11/01/17 20:07, Uwe Kleine-König wrote:
> >>
> >> On Wed, Jan 11, 2017 at 08:35:11PM +0100, Vicente Bergas wrote:
> >>>
> >>> Hello,
> >>> when using scripts/checkpatch.pl it may report:
> >>>   Unescaped left brace in regex is deprecated,
> >>>   passed through in regex at scripts/checkpatch.pl line 2267.
> >>
> >>
> >> I bet this scripts originates from the kernel. So I'd recommend to test
> >> if their version is affected to. If yes, report to them, if not, update
> >> barebox to latest Linux version.
> >
> >
> > In the Linux kernel, this was fixed in commit
> > 6b8c69e4384b0bcf1936c2137804840212daaf69 ("checkpatch: fix another left
> > brace warning"), which made it into the the 4.6 kernel.
> 
> This commit applies as is in barebox, so, can it be applied?
> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/patch/?id=6b8c69e4384b0bcf1936c2137804840212daaf69

Yes. Can you send this as patch to the list?

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: scripts/checkpatch.pl is deprecated

[Vicente Bergas]

On Mon, Jan 16, 2017 at 8:36 AM, Sascha Hauer <s.hauer@pengutronix.de> wrote:
> On Sun, Jan 15, 2017 at 08:42:42PM +0100, Vicente Bergas wrote:
>> On Thu, Jan 12, 2017 at 11:27 AM, Ian Abbott <abbotti@mev.co.uk> wrote:
>> > On 11/01/17 20:07, Uwe Kleine-König wrote:
>> >>
>> >> On Wed, Jan 11, 2017 at 08:35:11PM +0100, Vicente Bergas wrote:
>> >>>
>> >>> Hello,
>> >>> when using scripts/checkpatch.pl it may report:
>> >>>   Unescaped left brace in regex is deprecated,
>> >>>   passed through in regex at scripts/checkpatch.pl line 2267.
>> >>
>> >>
>> >> I bet this scripts originates from the kernel. So I'd recommend to test
>> >> if their version is affected to. If yes, report to them, if not, update
>> >> barebox to latest Linux version.
>> >
>> >
>> > In the Linux kernel, this was fixed in commit
>> > 6b8c69e4384b0bcf1936c2137804840212daaf69 ("checkpatch: fix another left
>> > brace warning"), which made it into the the 4.6 kernel.
>>
>> This commit applies as is in barebox, so, can it be applied?
>> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/patch/?id=6b8c69e4384b0bcf1936c2137804840212daaf69
>
> Yes. Can you send this as patch to the list?

Why does it need to be in the list? can not it be applied directly?

>
> Sascha
>
> --
> Pengutronix e.K.                           |                             |
> Industrial Linux Solutions                 | http://www.pengutronix.de/  |
> Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
> Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: scripts/checkpatch.pl is deprecated

[Sascha Hauer]

On Mon, Jan 16, 2017 at 06:34:19PM +0100, Vicente Bergas wrote:
> On Mon, Jan 16, 2017 at 8:36 AM, Sascha Hauer <s.hauer@pengutronix.de> wrote:
> > On Sun, Jan 15, 2017 at 08:42:42PM +0100, Vicente Bergas wrote:
> >> On Thu, Jan 12, 2017 at 11:27 AM, Ian Abbott <abbotti@mev.co.uk> wrote:
> >> > On 11/01/17 20:07, Uwe Kleine-König wrote:
> >> >>
> >> >> On Wed, Jan 11, 2017 at 08:35:11PM +0100, Vicente Bergas wrote:
> >> >>>
> >> >>> Hello,
> >> >>> when using scripts/checkpatch.pl it may report:
> >> >>>   Unescaped left brace in regex is deprecated,
> >> >>>   passed through in regex at scripts/checkpatch.pl line 2267.
> >> >>
> >> >>
> >> >> I bet this scripts originates from the kernel. So I'd recommend to test
> >> >> if their version is affected to. If yes, report to them, if not, update
> >> >> barebox to latest Linux version.
> >> >
> >> >
> >> > In the Linux kernel, this was fixed in commit
> >> > 6b8c69e4384b0bcf1936c2137804840212daaf69 ("checkpatch: fix another left
> >> > brace warning"), which made it into the the 4.6 kernel.
> >>
> >> This commit applies as is in barebox, so, can it be applied?
> >> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/patch/?id=6b8c69e4384b0bcf1936c2137804840212daaf69
> >
> > Yes. Can you send this as patch to the list?
> 
> Why does it need to be in the list? can not it be applied directly?

Could be, but I am lazy ;)
Anyway, in this case it was easy enough to wget/git-am the patch. Just
did that.

Sascha


-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox