From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-wm0-x236.google.com ([2a00:1450:400c:c09::236]) by bombadil.infradead.org with esmtps (Exim 4.89 #1 (Red Hat Linux)) id 1ej6Tv-00045x-Ni for barebox@lists.infradead.org; Tue, 06 Feb 2018 16:52:33 +0000 Received: by mail-wm0-x236.google.com with SMTP id g1so5026125wmg.2 for ; Tue, 06 Feb 2018 08:52:21 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <20180206093338.v5j5r2b3yha2ctju@pengutronix.de> References: <20180202111442.12444-1-aleksander@aleksander.es> <20180202111442.12444-8-aleksander@aleksander.es> <20180206093338.v5j5r2b3yha2ctju@pengutronix.de> From: Aleksander Morgado Date: Tue, 6 Feb 2018 17:51:59 +0100 Message-ID: List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH 07/10] ratp: implement ping as a standard ratp command To: Sascha Hauer Cc: barebox@lists.infradead.org On Tue, Feb 6, 2018 at 10:33 AM, Sascha Hauer wrote: > On Fri, Feb 02, 2018 at 12:14:39PM +0100, Aleksander Morgado wrote: >> Signed-off-by: Aleksander Morgado >> --- >> commands/Makefile | 1 + >> commands/ratp-ping.c | 38 ++++++++++++++++++++++++++++++++++++++ >> common/ratp.c | 27 --------------------------- > > Can we put the ratp commands to a separate directory like > common/ratp/commands/ or similar? > There doesn't seem to be very much code sharing between the regular > commands and their ratp correspondents. Most good commands are written > in the way that the functionality is in common code outside the command > file itself anyway. > I actually did that originally, but then implemented "md" for RATP and decided I could reuse part of the code doing the memory dump. But then no other command I implemented shared anything with the console counterpart... so yes, totally agree changing that would be much better. I did think of moving them to commands/ratp/* instead of common/ratp/commands/* though. Why do you suggest to have them in common/? Shouldn't they be closer to the console commands in the hierarchy? -- Aleksander https://aleksander.es _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox